From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com [209.85.222.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0CF04C651D for ; Thu, 15 Oct 2026 17:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792084774; cv=none; b=ldqucpDEBrIhrNjaNsa58Yh0rcMpzI/KZTOHdBN4Ni9fURcPPcCeoYcpzEZORiHIEA6N9KoIuMFhgjzE276WeNYjLgBFczQya0T4qfaZCUowMEtE3ZGzPUZ8S5twy1Bj6NJKSxmR/uhIsyyfLV8KKKGvQ22UCzSoXGwG/M9bsK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792084774; c=relaxed/simple; bh=tJoootuQrX0nPjs2wYqXe3DCOdBgRRUX2l69DqK3Z7A=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=aagmF5K60AFJNrATBeRchWsy4bLNapLj0VpzJXlPGk9p77I+JIT8wD2+5JqtANIo4bYlFqNLkDeqKNHxYB7RUrOEIo9BgDe6jJWQj8k3N9B/L40jc2wdKGoU2BC3n0FlkDB1XJI+Kjl8VAhRd9aReD01i7ZSUgpn1JtlZmzKAVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lfCOHw54; arc=none smtp.client-ip=209.85.222.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lfCOHw54" Received: by mail-ua1-f45.google.com with SMTP id a1e0cc1a2514c-982d6efbeadso409796241.0 for ; Thu, 15 Oct 2026 10:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792084764; x=1792689564; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=ZZvyPedXovvZDXPLa62gGgR2ST9LAGqR+oO13yEpFUg=; b=lfCOHw54JGGK4Mr46veh8M9LLjnRjZ2B/jdcW/TPrTPsHFYR1VsnRt8yAC2OQx8QoC wtpOKThGCAihlllyErS8Vu+AE8pDdEszZ19g2yOq7ARDJY70hgQUpb/hR57QQiKtgETV RyrsStBdAQ031IdK+rnn+U/GKejV0vwVz+wjPEf1GQX+tS3b4SgpGoQgPNN84L76E+6p Vk3MqcnScsnqEMJoEQo4Z4H0iQ/rmdDNOn0HeT8Y+hWtuACs4yakhAQc8LRb++ykmABd sWgxj/7Gi3dN4O2eIkq254ao/41ZirZafQrlplWKxDnON6BmZsFg862AIqzLZ4AZaxnt NYiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792084764; x=1792689564; h=content-transfer-encoding:content-type:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZZvyPedXovvZDXPLa62gGgR2ST9LAGqR+oO13yEpFUg=; b=hwskIuUQIcFW2Fkaeaco0AjhT5jxYVlITJE98rbWsQ3x8z4QqRKATjOhxtUH1ZAehx 7yY90Go92e2G6OuC8bS+E6GSam34jB30rTkwXzF5RvvwSXdaGKOStJbO0Vec5A7xC9ZV z9ohpuLvqGynXPh2zLkYc3amLWTWIgcFETF2jABnSjiqP/5bL383EIVVRrN32T2y5ufW cBdVJrW4/2aaE6pUZNApJ5xf9XBkIYgVBN6CgHA922R/bEJOsTPHFdcX3J8wm2buv6sx i/UhIiOrvortfG9Y+myUSmd+yBlxbYotMcDPanWBQ3ec2z8+owXr89CY7SuuHw2agwJq vNBA== X-Forwarded-Encrypted: i=1; AKwUvBwXb4fxTEJY1CcoFnz2q6hH6yFhMNodvLaAnSgVcIQy9nrQquJu3N35J88n0goYz2X5oWvvQ/obmN1AGV0=@vger.kernel.org X-Gm-Message-State: AFq9FYLXWhU+BmRbj8B4Us35Cfr3Mo9Nelr4nZSXItrVelCWrMNDRqFs 5WS0rBx8UuGy6B+xAX4lDyv+YXWGoaAZNA6rTLt5arGVJqKHEYcVJo6p X-Gm-Gg: AYBFou2PXxc6dddMJrUyp1Kfrx03TSTHOSH0zJP+G8esmvmyq1YmbX9qs8CPSR7TjMu tF1mR1vNH1yT8T3tZvICg0d7z8mUns8Y8Z8WEe0852JoySk44i7F/Z4Zxud0pjmCKcMcqYg0kFu 0U6cMvkc71AmRfzRkrslvfKf0/RHmx13YW+P5CGoDkfK2A13XpbH5L7p5MRa3h7HlbxxgKIJpVy v0IwfxvOQ3D8I3Rq22nfTFthS1FVeQpFvocGcxNXJoplzP8NEnwKQ2jp3IQU3I5FqjqQSPzqlLy yO4dTKKhkMo5SE8YJ/+xvFhppF2IPaUkLZoykl3Z0NIAlqHZsnnvLBCsholUada5/z9od0Y/PBg Nqyok3C/eM6nM72sjt/P7entODOwlSUAJ4XbAMwdc8hA87bnnyDiTzixiygqAyhkAYU+W9p65hq XmTu/69OeUke/txoOvooKhqiHW2EDMIZAVYeXAqzghOF4LOmV+zhLjI7uOe8CC2fmnWSNlfKlNX //YM0rE13zb5MaQJSQr3xX3AUJxM+5PsCiQcArTcLVYnc34EJ3pTABGYKLc7QRHFW2cwr2wNnHu T5Z+HtkFZUiwfGYRn93RjzMWD8rkZIqVSNL6lyfiVqDwxJqM X-Received: by 2002:a05:6102:370c:b0:7c3:2b19:6266 with SMTP id ada2fe7eead31-7cb3739fd7amr4589811137.22.1792084763651; Thu, 15 Oct 2026 10:19:23 -0700 (PDT) Received: from gmail.com (111.46.245.35.bc.googleusercontent.com. [35.245.46.111]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-9900490dd07sm12972678241.3.2026.10.15.10.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 10:19:23 -0700 (PDT) Date: Thu, 15 Oct 2026 13:19:22 -0400 From: Willem de Bruijn To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org Cc: Willem de Bruijn , Jason Wang , =?UTF-8?B?RXVnZW5pbyBQw6lyZXo=?= , Xuan Zhuo , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, virtualization@lists.linux.dev, Rusty Russell , Max Krasnyansky , Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org Message-ID: In-Reply-To: <6716834884238de0ab1ab313004044122aa2adbf.1792067836.git.mst@redhat.com> References: <6716834884238de0ab1ab313004044122aa2adbf.1792067836.git.mst@redhat.com> Subject: Re: [PATCH net-next v2 2/7] um: vector: honor virtio net hdr conversion failures Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Michael S. Tsirkin wrote: > virtio_net_hdr_to_skb() refuses packets whose checksum metadata > it cannot make sense of, but the vector raw transport ignored > its return value: rejected packets went on into the stack with > their metadata unvalidated. > > Propagate the failure. > > Assisted-by: LLM > Signed-off-by: Michael S. Tsirkin > --- > arch/um/drivers/vector_transports.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/um/drivers/vector_transports.c b/arch/um/drivers/vector_transports.c > index e1fb2a76fdff..8b7548458663 100644 > --- a/arch/um/drivers/vector_transports.c > +++ b/arch/um/drivers/vector_transports.c > @@ -210,7 +210,9 @@ static int raw_verify_header( > return 1; > > skb_set_network_header(skb, ETH_HLEN); > - virtio_net_hdr_to_skb(skb, vheader, virtio_legacy_is_little_endian()); > + if (virtio_net_hdr_to_skb(skb, vheader, > + virtio_legacy_is_little_endian()) < 0) > + return -1; Should this return 1, like the above? Not sure whether the verify_header return value is well defined beyond just boolean.