From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34AAD248867 for ; Sat, 22 Aug 2026 20:55:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787432155; cv=none; b=lcXCGtqx2DcEr5Zxqb/GMh8yj2gPy1quY+SlKKUHNlt167PoYkt/yG11fXEa6cDzMSax0sNUJXEctSX9joJs7dpoKsChl7pGOilifuZyS9uOiFANtD3P/EPruJuFlKvHFvDsKD5g1CW84p2AS068xhciQ6b9EjNQBqFn3voHSlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787432155; c=relaxed/simple; bh=d7Wm2ZfHIDm7ouPgbVQMroG5P5fb1VVVnpsqxt6VAFM=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=kVUzZQyd+HNHDbI5H3XSxJKdh5sNXlFVVkYt/YE5egkhmKp8x3/nmfDcKzH/GL2eESBHfm5AnVurq60MRY0aZbyHqWD7ljmFLGQKrR+k7zisOCxxdMRP/hHr3hQD6cnyospPWfGisf15PBE+wKTeZbPC/TdCk4BJdtTUvRnCDdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M/zinSad; arc=none smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M/zinSad" Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-836c43641baso43334697b3.0 for ; Sat, 22 Aug 2026 13:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787432153; x=1788036953; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=S5V/q31bjTfUMDrf97iKysR6FrEMNDpiONny2xwLCfs=; b=M/zinSadAfyr3ZE6JX2LkKzaqKA9MUTXOZqwfjdfX0YdBfHisMNlFmAKqqmCaNf+fo Jtfkqy+qEAhh5PmGON1wOH0G3dYvX6/uRx9gxxBkQ1NnDNJahtISGKSr4d9rBLgQTeKj dYjgk7UIgJi8FXiwfvk4llB54vMPdtK+W5LM+i1JCvrABKoVj/GQvJ7pRVODorgYKxdK qY6XMCMCG3p6MqgRyIFkjhbp7/NSFkQGfn2q1woZ9NDDijhfMNWNYiZtMP0VS2drbIua C4Xrh3BKqn1uTkp3dDebeN8ydWnsbCz0OetzchicGZ15sOL7h9iQ7is1Y5ce4vERKGKN szYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787432153; x=1788036953; h=content-transfer-encoding:content-type:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=S5V/q31bjTfUMDrf97iKysR6FrEMNDpiONny2xwLCfs=; b=G+2tl/73co+nxAtSso49YLrHoZCcnNA6XkD3ntatQFscB1K3Jorya1H3Pb+Pr4Gng6 ShyAAZBarm9j+Bdj5N0ifw2R+ddAAINQhEf/ny+zjnP7pnnbrVQHfLLzd+J7tWGbxhvy XdEVe8ZV+uO/jrGSsAhQwg6r3ILNZw30GkP0stCiQxf/SkhqKzyaH/ORR9a3wz9HsRDa +ZIIHvZgY7SM5hgfHTzmMU7N3c8tDdJVpxXcTuQJe4gUBI0SVk3fUtOhlfDShiliq/R5 N12hSb/BUo+nE/x5IGuz60teuKMT1hi2+KA99QbKRr+tKU5CYcnqmXmX58oAyG6ZP8rS TErQ== X-Forwarded-Encrypted: i=1; AHgh+RrNuvU7aBN0JezbrLPRevifekJGsJt8Z/4VVodnlc9xbcJUsop+m2d5r926vl13SRRBQ8pS5j5ACeRCR6I=@vger.kernel.org X-Gm-Message-State: AFuF++ky0LsU0d6nRCfmrdaEPGbwTRkRpgYYjVzhbivjjnU/5mYxWjr1 r08RX7LrUqZcdTgyg8IoymhE3zcY4SNQP1mIL/4rVq1awoB3qqv3+ASK X-Gm-Gg: AR+sD130qA8HeMHPSJOjXx8Ao9Vu5UnJROLBhJh99rvRt1ciPFGiiOdJgkSG9mIfJmO j3VDRRr5rJZ1D2Xen+5NbsCNazo4pZIfLsv++hW5T/DSECUjLPpUzWza6P5zZ42PbeVqTv/OivZ ecIFng41UMIMfsbHiwV2Xbsg1F8VUlbjjcDxZmEVBcMuf+Zf0N/goCwSA2ZFMFVvOXW3P40ggD2 2T8TLrcqznSLTxT/ri9f3cMW/HVmYnkyWh8pkyQI//Jz+ZEieC7D8sJHOKSv7PFSKPbawFxvgFX qYPDGoXubhbVACDxAkWcn7JqQ3pvwr2lTzTJfTf6AZ/5XCD6dQHfH3c3tWdk5+Lb1pmnurrdubp r80TbJWDEAfY8N6K+Y2lyxVeWFZA8fj6Jo5ACZN2JXCSts1GRkrGeO8VhxPArfa+DwjOtdB1KfI sIGQgEGDct/LQ62Kxb7alELuCuSvSxi1urP5cF2rQv1tGHnE6HzPXfYj0r5Crqcw1wEwyecBfXH KfFYGPux0rwHoUf7FuI+pRQhmIfGQ0q47hIvGWgfw== X-Received: by 2002:a05:690c:4392:b0:833:801:f715 with SMTP id 00721157ae682-849f4c71f3amr52253307b3.18.1787432153186; Sat, 22 Aug 2026 13:55:53 -0700 (PDT) Received: from gmail.com (234.207.85.34.bc.googleusercontent.com. [34.85.207.234]) by smtp.gmail.com with ESMTPSA id 00721157ae682-84cabe2570fsm14237647b3.38.2026.08.22.13.55.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2026 13:55:52 -0700 (PDT) Date: Sat, 22 Aug 2026 16:55:52 -0400 From: Willem de Bruijn To: Ilya Maximets , Jakub Kicinski , Ilya Maximets Cc: Norbert Szetei , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Aaron Conole , Eelco Chaudron , Steffen Klassert , Kuan-Ting Chen , "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, dev@openvswitch.org, Jongmin Jang , Willem de Bruijn Message-ID: In-Reply-To: <86c61c39-901e-489e-aec9-fafe639276e7@ovn.org> References: <34c64d08-0484-4f3b-b61a-ed68115d01a4@ovn.org> <20260821170950.3e278b1f@kernel.org> <86c61c39-901e-489e-aec9-fafe639276e7@ovn.org> Subject: Re: [PATCH net v3 0/3] net: don't strip zerocopy frag markers from a forwarded skb Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Ilya Maximets wrote: > On 8/22/26 2:09 AM, Jakub Kicinski wrote: > > On Fri, 21 Aug 2026 23:45:41 +0200 Ilya Maximets wrote: > >> Unfortunately, this needs a rebase now that a conflicting change > >> for skb_zerocopy() was merged: > > > > Ugh, I was supposed to merge this first, wasn't I? Sorry. > > Not a huge deal, I guess, the conflict is mechanical and the patches > are simple. I can take care of manual backports once we get the > 'failed to apply' emails. Just a bit of busy work. > > > I was hoping for Willem to TAL since skb_tx_error() is a tx ZC > > thing, now I realized that he wasn't CCed :S (please do so on v4) > > FWIW, I CCed a few people on v1 to have a conversation about a proper > fix, but that wasn't fruitful. So, if I were Norbert, I wouldn't > include them for the new versions either as doing so always feels like > me being annoying. :) Having a look now. > For now, the plan is to get v4 of these targeted fixes into net and > stable and then remove skb_tx_error() entirely once net-next is open, > as it seems to have lost all of its prior meaning. The original use case in tun_net_xmit introduced in commit 149d36f7187c ("tun: report orphan frags errors to zero copy callback") still exists. Not sure you can remove the function entirely. The bug is hit when this function is called with a cloned or shared skb. The original zerocopy path through tun_net_xmit was probably expected to not have this problem. Commit 0110d6f22f39 ("tun: orphan an skb on tx") explains why this orphan in tun_net_xmit was needed: a (vhost) zerocopy skb injected in tap1 arriving at tap2 and not being read there indefinitely. Such loops are not allowed for zerocopy. Commit 868eefeb17d4 ("tun: orphan frags on xmit") then added the frags orphan. Since an skb can be cloned on this tap to tap path, e.g., with a packet socket, I think the bug goes back to the original commit that introduced the first caller of skb_tx_error, commit 149d36f7187c ("tun: report orphan frags errors to zero copy callback") If respinning it may be worthile to link to this thread.