From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Quchaosheng <quchaosheng000406@163.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Oliver Hartkopp <socketcan@hartkopp.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Quchaosheng <quchaosheng000406@163.com>
Subject: Re: [PATCH v3 net] net/packet: guard the ll header push in packet_rcv_spkt()
Date: Tue, 29 Sep 2026 10:58:34 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.19517152cbe21@gmail.com> (raw)
In-Reply-To: <20260929073648.2748099-1-quchaosheng000406@163.com>
Quchaosheng wrote:
> Agreed, this is not a fix for that change. init_can_skb() is being fixed
> separately -- zjamg's patch, now 05/22 in Marc's tree.
>
> packet_rcv_spkt() is the only ll header restore that d549699048b4 left
> without a dev_has_header() check, and SOCK_PACKET reaches it. That is all
> this patch is.
Perfect. Thanks for verifying.
next prev parent reply other threads:[~2026-09-29 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 11:31 Quchaosheng
2026-09-28 22:55 ` Willem de Bruijn
2026-09-29 7:36 ` Quchaosheng
2026-09-29 14:58 ` Willem de Bruijn [this message]
2026-09-29 14:58 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.19517152cbe21@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quchaosheng000406@163.com \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®