From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98A484AD7D6 for ; Wed, 7 Oct 2026 14:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791384616; cv=none; b=AjLU6JHTDxJEhImZ5+xlSqdUyIVeJhN44rw0hUeM49NEP/pQDHqE6hUcdGOmowTkZ/dh3XHwwCLEPtEmgjF2c5lqUOo3c63MNRSzOBynmKYByqlvziYpCbvipXt8DQqrxb5hzwB8l9yrpd4+pyHi/87myoJe41vz4P6t5vZ8a/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791384616; c=relaxed/simple; bh=DtLW2TlvpGvM6hV7rxhC4fpV2L2eYZv026J/B1/JswE=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=e9/QQgsEjWU5YV/YeEIjS2/UsEPqe/s/4FWnVynUDURKAM5z0PTkrTlIlFc2YJUrYSfXFc73y21g5QgLrO28sb+DvIuK6pSvRdMD5bDRKbtSCsZ7plh/dUC6kscRaLnFe7tLRY3kGHySdnOKmCFMCjYXXsL+8W6tR8zwSAbd6Hg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fdz264Cp; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fdz264Cp" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-8b056d58f2aso14340507b3.2 for ; Wed, 07 Oct 2026 07:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791384608; x=1791989408; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=R5S9y3rm49FcBbD2GVDr+s54p4RcgRdmhC0n7fWz+ME=; b=fdz264Cp2G8Z/ltyHdIO0aIQSkeYspGBR3kVFF/2Ks4+3YFIWsJUI3x2KlmWnf6WP0 U8wXEbRCDfzMAsfeEvwFQ5xWZItwAvgSdXUKQ0wYqIfdGxsOsNrgdw+zz/0UlYDrUK+b Stm1zUFuHsKeYuXlHG2GrHdGtJGorQ3XR+2eWcSTquM0th9QDNdubXg9omqhP+02gsgV 9hdcopXhkdgqWXuU0Xhu/S5vSqbRTMDR98GodN/YHgaLNZxdFfPS6ps5caVe+3b/gMQz 5Nbr0ObPecxrNhF38cpixnYcnyaoD7U5GbHbnLcGlcOjNUS+ySmWHzamLhT480F8aWu/ /hYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791384608; x=1791989408; h=content-transfer-encoding:content-type:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=R5S9y3rm49FcBbD2GVDr+s54p4RcgRdmhC0n7fWz+ME=; b=VB1t343WeONINM58RTZbStZGosVUSxrAfjk6TiyblPJA55GGlXDc9e5bsk56QYBxtX rLHVbHQwvKUknweSmFeE3B62aytRwg25SQRB6iUD5S7yp/S0/J3cFUF3ImFZQl0Ywm1C PP1l4AYBOwCudBrVmFhb3D2KdYBJqDnh8H8FAAO4CpVdrVXTUMiAhIe/unubDvlj18Dp l8EGs0zuP8AfNR2QSHR/FGXmVCpKJkw167ASKPWKsQ/FJFdgs5rIVW24+AFyO5QBwjWz FPuzNcLvcMtROEL+VlPk+1l7eEHmlY34pRH61TaGww6kiV/FEzUil0eQr/e88oEPmYjV khgg== X-Forwarded-Encrypted: i=1; AKwUvBx0I9/f5IFGepxo1tt4dVlf8oQGo8rZWuWGyegNaUFP3MQ5VFnLNsXlxXu554enqKQMGD00IwAAJn3FkeM=@vger.kernel.org X-Gm-Message-State: AFq9FYJwJz9c5/vGuf6ZBAU66yXUZAsQyNsSp/D577mqMAyHK6Mvjz+O UeOHwxRvMlMs0tNWng7rsBNt4WE9/3P5ltOzFt+W0vbqtwm6eKDhZ1wo X-Gm-Gg: AYBFou3lESRUPfovlFn7EyVMo39TzDeYGuMFUw0zA1sLMQbAIVfK3q/CE2UsPke1V2u hpn3xyQY/1HbRhsINWTz5YONRkMnadNkx67SksALl7Q6PnEhODrNRMmmD023LYf0t4jSX45n7s5 gEie4+hYK2tiUbySO5RBdSKKW2EIiAk6j+EuggDvi+vZjkJDLDvZBJ96y7pudlN7VXZKr7YqBIk M1dwUqwBXWvCqsYYpFEv+UD+YTsRDVMSPIlQmlv4QM6n+1IIaGBYxK3KUDi0Dhy2UVABMUn1GQq XE+Le09NBCjzlk+/Qy8efv3kEoT+mdWDZfctqH65EL8ZJcIOF9AoTil3fJkW+iq61+z9ge041sj xy8Qf0YxceQZi/k49j8ttM2Ry4XOp9tAJll/XwMz1TI270CYZzPHJRycDuoItJmvIaJniALk0Aq AejgdyGpLJ1iXpqNG6Er3CKgfFiXJBo+Xt+NXLN0XdUfiJCKd9Xa+M4NQx+L6fjOwMiBg0eWerT 39dHdBvW/FAqn1w/1oENZXX2rD4OOUMX0RpnYq5lNyg4mJuScLjVUjX7PcSo3nu76Gyt4jT0j2i CEUNS2NdIpdnEFzFoSPBRAphramf1sTKx24Efw== X-Received: by 2002:a05:690c:3481:b0:8ae:c3f4:3da8 with SMTP id 00721157ae682-8b05b172ff5mr16418657b3.85.1791384608412; Wed, 07 Oct 2026 07:50:08 -0700 (PDT) Received: from gmail.com (111.46.245.35.bc.googleusercontent.com. [35.245.46.111]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8b05abb8b72sm9302657b3.34.2026.10.07.07.50.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 07:50:07 -0700 (PDT) Date: Wed, 07 Oct 2026 10:50:07 -0400 From: Willem de Bruijn To: Josef Bacik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kaiyuan Zhang , Mina Almasry , Willem de Bruijn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Josef Bacik Message-ID: In-Reply-To: <20261006-b4-skbuff-bug-on-v1-1-1b4434c5357c@toxicpanda.com> References: <20261006-b4-skbuff-bug-on-v1-0-1b4434c5357c@toxicpanda.com> <20261006-b4-skbuff-bug-on-v1-1-1b4434c5357c@toxicpanda.com> Subject: Re: [PATCH net-next 1/9] net: skbuff: don't leave stale bytes in skb_copy_and_csum_bits() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Josef Bacik wrote: > When skb_copy_and_csum_bits() reaches unreadable frags it returns 0 > after copying only the linear part, and the rest of the caller's buffer > is left as it was. The callers copy into a buffer that is about to go > out on the wire: an ICMP error quoting the offending packet, or a > driver's TX bounce buffer in skb_copy_and_csum_dev(). Neither buffer > is zeroed beforehand, so whatever was in memory there gets sent. > > Zero the part of the buffer we didn't fill. The checksum is already > wrong in this case, so the packet still gets dropped by the receiver, > it just doesn't carry anything it shouldn't. Only zero for a positive > @len, a negative one from a broken caller must not turn into a huge > memset(). > > Fixes: 65249feb6b3d ("net: add support for skbs with unreadable frags") > Assisted-by: LLM > Signed-off-by: Josef Bacik This should be a stand-alone fix sent to net (and stable)?