From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7606030C631 for ; Mon, 13 Jul 2026 03:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783914056; cv=none; b=T/wZXfJarL+Yr4HLB3fqd1KfJIY/DlnoanWxTdr1udlW/BKfIYmEE2ojCm3UivKWWVvYSxQKsXYXrpf34x6GKWKl0QMXGyhi/YPEJFuBB+EMXD8UCbusBktuTgRZoDd5YreTXybk6Rtj0BT05eOu8HtZTUZRZZMCn9YKJU6U1S0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783914056; c=relaxed/simple; bh=5h8jQL3TdcDQN5OyfaTjXVOYLwfig02OQQ0EFcveYAM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eIC51Q62YOcRAeBfrsArzuAxvMmv4G2gvO8iTGJOksC4nU76gXKDM9l+CHY+XeyosnaUGxA9Eu4R4NHJySyxkqWmwzZ0B6+q8b0EDkVaTx68Kx+4VqhBgO7/UUC6sfc8I4G9lSlDiaDqqxpYxONVIjsSG24luB8y4bWUH6NlPWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.tenstorrent.com; spf=pass smtp.mailfrom=tenstorrent.com; dkim=pass (2048-bit key) header.d=tenstorrent.com header.i=@tenstorrent.com header.b=gkUXyAm5; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.tenstorrent.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tenstorrent.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tenstorrent.com header.i=@tenstorrent.com header.b="gkUXyAm5" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-81e97f3b3efso7443747b3.3 for ; Sun, 12 Jul 2026 20:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tenstorrent.com; s=google; t=1783914052; x=1784518852; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=DD337bllPU0qOfiBQScd86xJr2rrEeEQWd3DGNprvhw=; b=gkUXyAm5E5CZVFNODwx4uGf6Xix1pEX0F5qP+5D9kGOIfyzJrxugvnWtI5v4ZUfC93 IsJWan3OyFwKrmUvC7IV3AXeoPP9vgMeEW1EU5QpVuX7z86RMRLJXLMk56WVG9VoVBL6 QGL0n/ziG4uOP5MGKCXvNokqhtL+zeu/PmZ9OB4wGCO9JLDVW8pO6ZoDRvS6LoVqa3rs FQG5rpucSwESFexDcIHJ8BDiStnvtsjJHkw9tbBENcksFymqmGw6zRTd/GXiNtLNWdqj dR8yPcqbElvsUezup4k4uwuNJae14aLFzZerY67MymbsY0mot92cH2N1D4z3Ng3mOK0s FshQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783914052; x=1784518852; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DD337bllPU0qOfiBQScd86xJr2rrEeEQWd3DGNprvhw=; b=idSeS8Vy4SykuxtsJGwXo6eXWVqF3N5VqI4eLOxE+pArB4/GgvG7Q7LAzwSClbuqlB K2HA62PRXgJsRLPeNMn4/EGb2/k6+wnXqO3gLL9IQY5LDt4GuxdsIOMJmtAKbryv1k0N 2aEI4cY48Y4VRU+zjZuZK+cCqOzyKzrOSWUCxmhhgG6E924riEqk83VKJgP7HvxnDcBU ATUGV+CLkqdbLAqiMyIe4gT0NKTU7qCJ/gyJ1stDf7cx+JTxll/JB1HgGozDt8NlDByJ FuHOK0Pg9aBCmGXkmmBbySkpNMOM/Ce4NFawXAzskw/ejt/Du6M8R1DUMLhCp1PdCA/d Yn3A== X-Forwarded-Encrypted: i=1; AHgh+RpaLXum+vhRY6yAU4IHii5ACtFkF0JN3s6amoutdTYNjw7DU+VeNeKWxv8eI22Xyr1ABShfbSaUd4a5wCI=@vger.kernel.org X-Gm-Message-State: AOJu0YwZqnStiapNrkpfx8U+4LD8cQwSVFV3/xMrSzWWhHemwryAMcdN X3n1BMfOX/qYY+cjtIlr6XfgduWekxLjHzl3dSGGiMZQgFP9rJLzJtpeA7eXi78RGNM= X-Gm-Gg: AfdE7clsWOn2CGioJIrG978Lxh0siA1KvJxjEjZ9Kjr2Ly2xRw7qZKmUns5iNpakO3g ZbX6h+8hm9SDCSvEb+/p7HuHF0gGHydvoYaxv6NuNO5GPaIsvA9kaO7ks+4DD1eF3XP5NevTuot 8XLDm+oj6D7/QA6jnuqU0mVYWKDRmBkHd5KBpKgG06jLW+v5930YCSgpEGY9gi4pJfQVaepewFO nayotUDBhfN09bwOEctaMnd6TUHBExCHzGi26ZkK+D3iQt/C6Ca67kdDpU//T4pN94ET+mK8hm1 4pxNzD/4LoVA4cN30vT7wuMbgsSJwTiIaJAOjVL0G4WBuHq8r2ATeWfpa1WgZ5cYmrw/659wJ7t 9GxaLaKqP2a1TYNopraxJA3X1+htNyuthyr5+t2GHG9MzDhinEOq4px9evjeAohMrrBd50YSjT6 nM4HI6oSgOrvXMiqDmDc+3YJQn6oXUXkaJzrNn/QDNx5UF4wIXVP6wPcz0Bw== X-Received: by 2002:a05:690c:6981:b0:80e:2917:4b01 with SMTP id 00721157ae682-81e9003e955mr55511657b3.27.1783914052406; Sun, 12 Jul 2026 20:40:52 -0700 (PDT) Received: from toolbox ([2600:1700:220:59e0:55c1:a162:6cca:b98a]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81e6c249b87sm104348967b3.49.2026.07.12.20.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 20:40:52 -0700 (PDT) Date: Sun, 12 Jul 2026 22:40:22 -0500 From: Anirudh Srinivasan To: Yixun Lan Cc: Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "James E.J. Bottomley" , "Martin K. Petersen" , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] Add UFS Host driver support for SpacemiT K3 SoC Message-ID: References: <20260702-08-k3-ufs-support-v1-0-1a64a3ab128f@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260702-08-k3-ufs-support-v1-0-1a64a3ab128f@kernel.org> Hi Yixun, On Thu, Jul 02, 2026 at 02:31:34AM +0000, Yixun Lan wrote: > This series try to add UFS support for SpacemiT K3 SoC, the controller > components consists of System Bus Interface Unit, UFS Host Controller > Interface, UFS Transport Protocol Layer, UFS Host Registers, Device > Management Entity (DME), Transport Layer, Network Layer, Data Link > Layer, PHY Adapter Layer, and M-PHY Interface. A more detail functional > block diagram can be found in SpacemiT website, chapter 9.7.3 [1] > > Please note, in order to test this driver, the UFS clock driver[2] here > should be applied first as a prerequisite patch. > > One known issue is that the device will occasionally raise BKOPS interrupt > when doing some high load test, log from dmesg shows > > [ 806.710763] ufshcd-spacemit c0e00000.ufshc: ufshcd_bkops_exception_event_handler: device raised urgent BKOPS exception for bkops status 1 > > Link: https://spacemit.com/community/document/info?nodepath=hardware/key_stone/k3/k3_docs/k3_usermanual/09_memory_storage.md&lang=en [1] > Link: https://lore.kernel.org/all/20260630-06-clk-ufs-support-v1-0-cf7521d1d0fe@kernel.org/ [2] > Signed-off-by: Yixun Lan I see this during probe on a k3-pico-itx. Does the UFS chip on board have an RPMB block on it? Is this error of any concern. [ 5.957864] ufshcd-spacemit c0e00000.ufshc: ufshcd_scsi_add_wlus: BOOT WLUN not found [ 5.963319] bus_add_device: cannot add device 'ufs_rpmb0' to unregistered bus 'ufs_rpmb' [ 5.971155] ufshcd-spacemit c0e00000.ufshc: Failed to register UFS RPMB device 0 Regards Anirudh Srinivasan > --- > Yixun Lan (3): > scsi: ufs: spacemit: dt-bindings: Add UFS controller for K3 SoC > scsi: ufs: spacemit: k3: Add UFS Host Controller driver > riscv: dts: spacemit: k3: Add UFS support > > .../devicetree/bindings/ufs/spacemit,k3-ufshc.yaml | 54 ++ > arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts | 4 + > arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 4 + > arch/riscv/boot/dts/spacemit/k3.dtsi | 13 + > drivers/ufs/host/Kconfig | 12 + > drivers/ufs/host/Makefile | 1 + > drivers/ufs/host/ufs-spacemit.c | 931 +++++++++++++++++++++ > drivers/ufs/host/ufs-spacemit.h | 90 ++ > 8 files changed, 1109 insertions(+) > --- > base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482 > change-id: 20260605-08-k3-ufs-support-c8b308e415e2 > > Best regards, > -- > Yixun Lan >