From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755943AbbCFQJS (ORCPT ); Fri, 6 Mar 2015 11:09:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49442 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754106AbbCFQJP (ORCPT ); Fri, 6 Mar 2015 11:09:15 -0500 From: Jes Sorensen To: Julia Lawall Cc: Quentin Lambert , Larry Finger , Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] staging: rtl8723au: Remove unnecessary OOM message References: <20150306082140.GA9740@sloth> Date: Fri, 06 Mar 2015 11:08:58 -0500 In-Reply-To: (Julia Lawall's message of "Fri, 6 Mar 2015 10:33:23 -0500 (EST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Julia Lawall writes: > On Fri, 6 Mar 2015, Jes Sorensen wrote: > >> Quentin Lambert writes: >> > This patch reduces the kernel size by removing error messages that duplicate >> > the normal OOM message. >> > >> > A simplified version of the semantic patch that finds this problem is as >> > follows: (http://coccinelle.lip6.fr) >> >> This patch removes useful warnings about what allocation failed. The >> messages removed are NOT duplicate! > > Is it really the case that the information can't be reconstructed from the > information generated by kmalloc on failure? To my understanding there is > a stack trace, and from scanning through the changes I see only one change > per function, so perhaps the stack trace already makes it clear where the > problem occurred? It may be possible to backtrack, but this change just makes it harder. There are tons of real issues to fix in this driver, this patch just increases the risk of patch conflicts for no real gain. Jes