From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751272AbbEXObT (ORCPT ); Sun, 24 May 2015 10:31:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45570 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183AbbEXObE (ORCPT ); Sun, 24 May 2015 10:31:04 -0400 From: Jes Sorensen To: tolga ceylan Cc: Benjamin Romer , David Kershner , Greg Kroah-Hartman , sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static References: <1431750141-5660-1-git-send-email-tolga.ceylan@gmail.com> <55613D63.9070505@gmail.com> Date: Sun, 24 May 2015 10:30:56 -0400 In-Reply-To: <55613D63.9070505@gmail.com> (tolga ceylan's message of "Sat, 23 May 2015 19:54:27 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tolga ceylan writes: > On 05/15/2015 09:22 PM, Tolga Ceylan wrote: >> visorchipset_file_init() and visorchipset_file_cleanup() functions >> do not seem to be used from anywhere else and now are declared >> as static. Sparse emitted "not declared" warnings for these two >> functions. >> >> Signed-off-by: Tolga Ceylan >> --- >> drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c >> index ca22f49..66ae3d0 100644 >> --- a/drivers/staging/unisys/visorbus/visorchipset.c >> +++ b/drivers/staging/unisys/visorbus/visorchipset.c >> @@ -2351,7 +2351,7 @@ static const struct file_operations visorchipset_fops = { >> .mmap = visorchipset_mmap, >> }; >> >> -int >> +static int >> visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel) >> { >> int rc = 0; >> @@ -2460,7 +2460,7 @@ cleanup: >> return rc; >> } >> >> -void >> +static void >> visorchipset_file_cleanup(dev_t major_dev) >> { >> if (file_cdev.ops) >> > > I haven't received a response for this patch. Just checking back. > > Regards, > Tolga Ceylan I don't think there is anything wrong with your patch. However, there is a lot of active development going to clean up the code in the unisys tree right now, and your patch conflicts with that. I would prefer to hold off with this for now, until it settles down a bit. Cheers, Jes