Re: [PATCH] sysfs stuff for eisa bus [1/3]

[Marc Zyngier <mzyngier@freesurf.fr>]

>>>>> "AB" == Andries Brouwer <Andries.Brouwer@cwi.nl> writes:

AB> This morning, just for fun, I retrieved an old *.CFG directory
AB> from the attic. Of the about 300 files, about half were not in
AB> your list. A patch is given below.

Thanks a lot.

AB> Of the ones that had an ID in your list, many mentioned different
AB> revisions or firmware etc. The NAME= given in a .CFG file belongs
AB> to that file, but not at all to the ID. This is a different
AB> argument against having such a list in the kernel source: it leads
AB> to confusion when the kernel prints an incorrect type or model
AB> number, and people will blame driver errors on the kernel
AB> "misunderstanding".

Indeed. I already cleaned up several entries myself (the AXP
ones...).

AB>     From: Alan Cox <alan@lxorguk.ukuu.org.uk>
AB>     I think a ".ids" file list is valuable. It can be used for things like
AB>     EISA card identification obviously but it also has a big value for
AB>     "lseisa" "lspnp" and friends (and hopefully when someone fixes the
AB>     device model "lsdev").

AB> Yes, lists are fine, but not in the kernel source.

Ok, I'll remove it, and will put it somewhere else.

Does someone have something to say about the code itself, specially
about the hacked drivers ? I haven't heard anything about it yet...

Thanks,

        M.
-- 
Places change, faces change. Life is so very strange.