From: Marc Zyngier <mzyngier@freesurf.fr>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Keep de2104x quiet
Date: 04 Apr 2003 20:01:53 +0200 [thread overview]
Message-ID: <wrpsmsydtv2.fsf@hina.wild-wind.fr.eu.org> (raw)
Jeff,
The included patch tries to keep the de2104x driver quiet if there is
link change. Without this patch, I'm getting lots of :
eth0: link up, media 10baseT-HD
eth0: link up, media 10baseT-HD
eth0: link up, media 10baseT-HD
about one a minute... Quite annoying. With this patch, the driver only
logs when state changes (which is already taken care of in
de_link_up()).
Tested on an AlphaStation-500 (21040, UP).
Thanks,
M.
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1004 -> 1.1005
# drivers/net/tulip/de2104x.c 1.15 -> 1.16
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/04/04 maz@hina.wild-wind.fr.eu.org 1.1005
# Keep the de2104x driver quiet if link stays up.
# --------------------------------------------
#
diff -Nru a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
--- a/drivers/net/tulip/de2104x.c Fri Apr 4 19:56:27 2003
+++ b/drivers/net/tulip/de2104x.c Fri Apr 4 19:56:27 2003
@@ -984,11 +984,7 @@
add_timer(&de->media_timer);
if (!netif_carrier_ok(dev))
de_link_up(de);
- else
- if (netif_msg_timer(de))
- printk(KERN_INFO "%s: %s link ok, status %x\n",
- dev->name, media_name[de->media_type],
- status);
+
return;
}
--
Places change, faces change. Life is so very strange.
next reply other threads:[~2003-04-04 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-04 18:01 Marc Zyngier [this message]
2003-04-04 18:12 ` Jeff Garzik
2003-04-04 18:40 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrpsmsydtv2.fsf@hina.wild-wind.fr.eu.org \
--to=mzyngier@freesurf.fr \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®