From: Jeff Moyer <jmoyer@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] blktrace: re-write setting q->blk_trace
Date: Thu, 29 Oct 2015 16:52:55 -0400 [thread overview]
Message-ID: <x491tcd5rdk.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <56328634.7030702@kernel.dk> (Jens Axboe's message of "Fri, 30 Oct 2015 05:48:52 +0900")
Jens Axboe <axboe@kernel.dk> writes:
> On 10/30/2015 05:46 AM, Jeff Moyer wrote:
>> Jens Axboe <axboe@kernel.dk> writes:
>>
>>> On 10/30/2015 04:19 AM, Davidlohr Bueso wrote:
>>>>
>>>>> The patch itself looks ok, but it doesn't seem to apply to a recent
>>>>> kernel tree. It appears as though it is white-space damaged. Would you
>>>>> mind re-sending it?
>>>>
>>>> Hmm sorry about that. I thought I had based it against that day's
>>>> tip/master.
>>>> Anyway, here is v3 which is against tip/master as of
>>>> 338e29ba93639138fafb9fb5ba946fd99a512aae.
>>>
>>> Thanks, this is definitely cleaner. Your patch is still pretty
>>> mangled, though. I had to hand apply it. Please check the result:
>>
>> Heh, and here I just assumed the problem was on my end.
>>
>>> http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.4/core&id=cdea01b2bf98affb7e9c44530108a4a28535eee8
>>
>> That looks fine, except you're missing the 'R' in Reviewed-by.
>
> e-viewed. Electronically viewed by jeff?
Heh. Well, that's not wrong! ;-)
next prev parent reply other threads:[~2015-10-29 20:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 3:05 [PATCH] " Davidlohr Bueso
2015-10-27 3:14 ` [PATCH v2] " Davidlohr Bueso
2015-10-28 21:37 ` Jeff Moyer
2015-10-29 19:19 ` Davidlohr Bueso
2015-10-29 19:35 ` Jeff Moyer
2015-10-29 20:28 ` Jens Axboe
2015-10-29 20:46 ` Jeff Moyer
2015-10-29 20:48 ` Jens Axboe
2015-10-29 20:52 ` Jeff Moyer [this message]
2015-10-29 21:05 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x491tcd5rdk.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome