From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753106AbbFHTuF (ORCPT ); Mon, 8 Jun 2015 15:50:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50811 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752220AbbFHTt6 (ORCPT ); Mon, 8 Jun 2015 15:49:58 -0400 From: Jeff Moyer To: Tejun Heo Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, vgoyal@redhat.com, avanzini.arianna@gmail.com Subject: Re: [PATCHSET block/for-4.2/writeback] block, cgroup: make cfq charge async IOs to the appropriate blkcgs References: <1433753973-23684-1-git-send-email-tj@kernel.org> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Mon, 08 Jun 2015 15:49:56 -0400 In-Reply-To: <1433753973-23684-1-git-send-email-tj@kernel.org> (Tejun Heo's message of "Mon, 8 Jun 2015 17:59:25 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tejun Heo writes: > Hello, > > cfq has always charged all async IOs to the root cgroup. It didn't > have much choice as writeback didn't know about cgroups and there was > no way to tell who to blame for a given writeback IO. writeback > finally grew support for cgroups and now tags each writeback IO with > the appropriate cgroup to charge it against. > > This patchset updates cfq so that it follows the blkcg each bio is > tagged with. Async cfq_queues are now shared across cfq_group, which > is per-cgroup, instead of per-request_queue cfq_data. This makes all > IOs follow the weight based IO resource distribution implemented by > cfq. > > This patchset contains the following 8 patches. > > 0001-cfq-iosched-simplify-control-flow-in-cfq_get_queue.patch > 0002-cfq-iosched-fix-async-oom-queue-handling.patch > 0003-cfq-iosched-fix-oom-cfq_queue-ref-leak-in-cfq_set_re.patch > 0004-cfq-iosched-minor-cleanups.patch > 0005-cfq-iosched-remove-gfp_mask-from-cfq_find_alloc_queu.patch > 0006-cfq-iosched-move-cfq_group-determination-from-cfq_fi.patch > 0007-cfq-iosched-fold-cfq_find_alloc_queue-into-cfq_get_q.patch > 0008-cfq-iosched-charge-async-IOs-to-the-appropriate-blkc.patch Hi, Tejun, Assuming you're ok with dropping patch 5, I'll review patches 6-8 once they've been reworked to account for that. I took a look at them, and they look OK to me. But, if they are going to change, I'd rather wait to ack the final versions. Cheers, Jeff