From: Jeff Moyer <jmoyer@redhat.com>
To: Corrado Zoccolo <czoccolo@gmail.com>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>,
Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [RFC V2 PATCH 3/5] cfq-iosched: reimplement priorities using different service trees
Date: Mon, 26 Oct 2009 11:08:48 -0400 [thread overview]
Message-ID: <x491vkqyyyn.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <4e5e476b0910210937y71d2018en2b8b4a23c4bb1aa1@mail.gmail.com> (Corrado Zoccolo's message of "Wed, 21 Oct 2009 18:37:41 +0200")
Corrado Zoccolo <czoccolo@gmail.com> writes:
> On Wed, Oct 21, 2009 at 5:54 PM, Jeff Moyer <jmoyer@redhat.com> wrote:
>> Corrado Zoccolo <czoccolo@gmail.com> writes:
>>> + * Index in the service_trees.
>>> + * IDLE is handled separately, so it has negative index
>>> + */
>>> +enum wl_prio_t {
>>> + IDLE_WORKLOAD = -1,
>>> + BE_WORKLOAD = 0,
>>> + RT_WORKLOAD = 1
>>> +};
>>
>> What's wrong with IOPRIO_CLASS_(RT|BE|IDLE)? Why invent another enum?
> Because I want to index inside my internal structures, and I have no
> control over the former ones.
Well, I already know and understand IOPRIO*, and it seems like it maps
exactly to what you're doing. I'll leave it up to Jens, though, this is
a minor detail.
Cheers,
Jeff
prev parent reply other threads:[~2009-10-26 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 18:12 Corrado Zoccolo
2009-10-21 15:54 ` Jeff Moyer
2009-10-21 16:37 ` Corrado Zoccolo
2009-10-26 15:08 ` Jeff Moyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x491vkqyyyn.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=czoccolo@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®