From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751391AbcEIOgD (ORCPT ); Mon, 9 May 2016 10:36:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59747 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbcEIOgB (ORCPT ); Mon, 9 May 2016 10:36:01 -0400 From: Jeff Moyer To: Paolo Valente Cc: Jens Axboe , Tejun Heo , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, broonie@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH BUGFIX] block: add missing group association in bio_split References: <1462567512-3007-1-git-send-email-paolo.valente@linaro.org> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Mon, 09 May 2016 10:35:58 -0400 In-Reply-To: (Jeff Moyer's message of "Mon, 09 May 2016 10:19:33 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 09 May 2016 14:36:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeff Moyer writes: > Paolo Valente writes: > >> @@ -1811,6 +1811,11 @@ struct bio *bio_split(struct bio *bio, int sectors, >> >> bio_advance(bio, split->bi_iter.bi_size); >> >> +#ifdef CONFIG_BLK_CGROUP >> + if (bio->bi_css) >> + bio_associate_blkcg(split, bio->bi_css); >> +#endif >> + >> return split; >> } >> EXPORT_SYMBOL(bio_split); > > Get rid of the #ifdefery. This should be just: > > bio_associate_blkcg(split, bio->bi_css); Gah, I see that the bi_css member is only present for CONFIG_BLK_CGROUP. I guess we'll have to live with the ifdef. -Jeff