From: Jeff Moyer <jmoyer@redhat.com>
To: Corrado Zoccolo <czoccolo@gmail.com>
Cc: "Zhang\, Yanmin" <yanmin_zhang@linux.intel.com>,
Shaohua Li <shaohua.li@intel.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jens.axboe\@oracle.com" <jens.axboe@oracle.com>, "Zhang\,
Yanmin" <yanmin.zhang@intel.com>
Subject: Re: [PATCH]cfq-iosched: don't take requests with long distence as close
Date: Fri, 15 Jan 2010 14:45:50 -0500 [thread overview]
Message-ID: <x494omnp2xd.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <4e5e476b1001151132l406054f6xcc47b94e817d3af0@mail.gmail.com> (Corrado Zoccolo's message of "Fri, 15 Jan 2010 20:32:10 +0100")
Corrado Zoccolo <czoccolo@gmail.com> writes:
> Hi Jeff,
> I think this patch has the same flaw as Shaohua's.
> The seekiness check that you introduce in cfq_rq_close is already
> present in its caller, cfq_close_cooperator, so it is not effective.
I don't think so. There are two queues, here. One queue is checked by
the caller, and that is the cur_cfqq. The __cfqq needs to also be
checked.
> Up to now, the only patch that improves this situation is the one that
> changes the unmerge policy to unmerge after a single time slice.
Yes, I definitely agree with that, and I think that patch should go in.
Cheers,
Jeff
next prev parent reply other threads:[~2010-01-15 19:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-24 0:55 cfq-iosched: tiobench regression Shaohua Li
2009-12-24 7:48 ` Gui Jianfeng
2009-12-24 9:19 ` Shaohua Li
2009-12-24 11:40 ` Corrado Zoccolo
2009-12-25 10:16 ` Corrado Zoccolo
2009-12-28 2:02 ` Shaohua Li
2009-12-28 2:03 ` [PATCH]cfq-iosched: don't take requests with long distence as close Shaohua Li
2009-12-28 8:36 ` Corrado Zoccolo
2009-12-28 8:46 ` Shaohua Li
2009-12-28 9:11 ` Corrado Zoccolo
2009-12-28 9:28 ` Shaohua Li
2009-12-28 9:40 ` Corrado Zoccolo
2009-12-28 12:16 ` Jens Axboe
2010-01-04 14:58 ` Jeff Moyer
2010-01-05 21:16 ` Jeff Moyer
2010-01-06 1:19 ` Li, Shaohua
2010-01-07 13:44 ` Corrado Zoccolo
2010-01-07 14:30 ` Jeff Moyer
2010-01-11 5:20 ` Zhang, Yanmin
2010-01-11 15:05 ` Corrado Zoccolo
2010-01-12 2:43 ` Zhang, Yanmin
2010-01-15 19:32 ` Corrado Zoccolo
2010-01-15 19:45 ` Jeff Moyer [this message]
2010-01-15 20:24 ` Corrado Zoccolo
2010-01-15 20:26 ` Jeff Moyer
2009-12-28 3:19 ` [PATCH]cfq-iosched: split seeky coop queues after one slice Shaohua Li
2009-12-28 8:40 ` Corrado Zoccolo
2009-12-28 8:52 ` Shaohua Li
2010-01-04 15:04 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x494omnp2xd.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=czoccolo@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=yanmin.zhang@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®