From: Jeff Moyer <jmoyer@redhat.com>
To: Jens Axboe <axboe@fb.com>
Cc: Shaohua Li <shli@fb.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blk: don't account discard request size
Date: Wed, 13 May 2015 11:00:49 -0400 [thread overview]
Message-ID: <x49617w5xpa.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <55535D9C.3050706@fb.com> (Jens Axboe's message of "Wed, 13 May 2015 10:20:12 -0400")
Jens Axboe <axboe@fb.com> writes:
> That would be better. But I'm still not sure we want to turn off
> accounting for discards. For the mixed write/discard cases it's
> definitely confusing. The better option would be to account it as a
> discard and not a write. Preferably in a way that would not break
> existing tools, but so that they could get updated to support it.
Are you suggesting adding a few fields to the end of diskstats or adding
a new proc file altogether? (or something else?)
Cheers,
Jeff
next prev parent reply other threads:[~2015-05-13 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 21:46 Shaohua Li
2015-05-13 13:10 ` Jeff Moyer
2015-05-13 14:20 ` Jens Axboe
2015-05-13 15:00 ` Jeff Moyer [this message]
2015-05-13 15:22 ` Jens Axboe
2015-05-13 15:48 ` Jeff Moyer
2015-05-13 15:22 ` Shaohua Li
2015-05-13 15:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49617w5xpa.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®