From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933039Ab1D0OFs (ORCPT ); Wed, 27 Apr 2011 10:05:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61608 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932858Ab1D0OFr (ORCPT ); Wed, 27 Apr 2011 10:05:47 -0400 From: Jeff Moyer To: Lukas Czerner Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Dmitry Monakhov , Jens Axboe Subject: Re: [PATCH 2/2] blkdev: Simple cleanup in blkdev_issue_zeroout() References: <1303303172-22404-1-git-send-email-lczerner@redhat.com> <1303303172-22404-2-git-send-email-lczerner@redhat.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Wed, 27 Apr 2011 10:05:42 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lukas Czerner writes: > In blkdev_issue_zeroout() we are submitting regular WRITE bios, so we do > not need to check for -EOPNOTSUPP specifically in case of error. Also > there is no need to have label submit: because there is no way to jump > out from the while cycle without an error and we really want to exit, > rather than try again. Looks good. While we're at it: while (nr_sects != 0) { sz = min((sector_t) PAGE_SIZE >> 9 , nr_sects); if (sz == 0) /* bio has maximum size possible */ break; how could sz be equal to zero there? Reviewed-by: Jeff Moyer Cheers, Jeff