mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Jens Axboe <jaxboe@fusionio.com>, Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v2 2/2] blktrace: add FLUSH/FUA support
Date: Wed, 10 Aug 2011 09:53:50 -0400	[thread overview]
Message-ID: <x497h6ls781.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1312957924-2316-2-git-send-email-namhyung@gmail.com> (Namhyung Kim's message of "Wed, 10 Aug 2011 15:32:04 +0900")

Namhyung Kim <namhyung@gmail.com> writes:

> Add FLUSH/FUA support to blktrace. As FLUSH precedes WRITE and/or
> FUA follows WRITE, use the same 'F' flag for both cases and
> distinguish them by their (relative) position. The end results
> look like (other flags might be shown also):
>
>  - WRITE:            W
>  - WRITE_FLUSH:      FW
>  - WRITE_FUA:        WF
>  - WRITE_FLUSH_FUA:  FWF

I was hoping we'd go with Jens' suggestion of relacing W with F for flush,
and have FUA appear after that.  However, I can live with this, so if
others like it, it's fine by me.

Thanks for doing this, Namhyung!

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>

  reply	other threads:[~2011-08-10 13:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10  6:32 [PATCH 1/2] Move some REQ flags to the common bio/request area Namhyung Kim
2011-08-10  6:32 ` [PATCH v2 2/2] blktrace: add FLUSH/FUA support Namhyung Kim
2011-08-10 13:53   ` Jeff Moyer [this message]
2011-08-11  8:36     ` Jens Axboe
2011-08-10 13:52 ` [PATCH 1/2] Move some REQ flags to the common bio/request area Jeff Moyer
2011-08-11  8:36 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x497h6ls781.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=hch@lst.de \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@gmail.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®