From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2411CC4CEC5 for ; Thu, 12 Sep 2019 14:00:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05FB12084D for ; Thu, 12 Sep 2019 14:00:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732388AbfILOAN (ORCPT ); Thu, 12 Sep 2019 10:00:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53250 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731455AbfILOAM (ORCPT ); Thu, 12 Sep 2019 10:00:12 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4C1363082D9E; Thu, 12 Sep 2019 14:00:12 +0000 (UTC) Received: from segfault.boston.devel.redhat.com (segfault.boston.devel.redhat.com [10.19.60.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9365760872; Thu, 12 Sep 2019 14:00:11 +0000 (UTC) From: Jeff Moyer To: Joe Perches Cc: Dan Williams , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH 00/13] nvdimm: Use more common kernel coding style References: X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 Date: Thu, 12 Sep 2019 10:00:10 -0400 In-Reply-To: (Joe Perches's message of "Wed, 11 Sep 2019 19:54:30 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 12 Sep 2019 14:00:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches writes: > Rather than have a local coding style, use the typical kernel style. The coding style isn't that different from the core kernel, and it's still quite readable. I'd rather avoid the churn and the risk of introducing regressions. This will also make backports to stable more of a pain, so it isn't without cost. Dan, is this really something you want to do? -Jeff > > Joe Perches (13): > nvdimm: Use more typical whitespace > nvdimm: Move logical continuations to previous line > nvdimm: Use octal permissions > nvdimm: Use a more common kernel spacing style > nvdimm: Use "unsigned int" in preference to "unsigned" > nvdimm: Add and remove blank lines > nvdimm: Use typical kernel brace styles > nvdimm: Use typical kernel style indentation > nvdimm: btt.h: Neaten #defines to improve readability > nvdimm: namespace_devs: Move assignment operators > nvdimm: Use more common logic testing styles and bare ; positions > nvdimm: namespace_devs: Change progess typo to progress > nvdimm: Miscellaneous neatening > > drivers/nvdimm/badrange.c | 22 +- > drivers/nvdimm/blk.c | 39 ++-- > drivers/nvdimm/btt.c | 249 +++++++++++---------- > drivers/nvdimm/btt.h | 56 ++--- > drivers/nvdimm/btt_devs.c | 68 +++--- > drivers/nvdimm/bus.c | 138 ++++++------ > drivers/nvdimm/claim.c | 50 ++--- > drivers/nvdimm/core.c | 42 ++-- > drivers/nvdimm/dax_devs.c | 3 +- > drivers/nvdimm/dimm.c | 3 +- > drivers/nvdimm/dimm_devs.c | 107 ++++----- > drivers/nvdimm/e820.c | 2 +- > drivers/nvdimm/label.c | 213 +++++++++--------- > drivers/nvdimm/label.h | 6 +- > drivers/nvdimm/namespace_devs.c | 472 +++++++++++++++++++++------------------- > drivers/nvdimm/nd-core.h | 31 +-- > drivers/nvdimm/nd.h | 94 ++++---- > drivers/nvdimm/nd_virtio.c | 20 +- > drivers/nvdimm/of_pmem.c | 6 +- > drivers/nvdimm/pfn_devs.c | 136 ++++++------ > drivers/nvdimm/pmem.c | 57 ++--- > drivers/nvdimm/pmem.h | 2 +- > drivers/nvdimm/region.c | 20 +- > drivers/nvdimm/region_devs.c | 160 +++++++------- > drivers/nvdimm/security.c | 138 ++++++------ > drivers/nvdimm/virtio_pmem.c | 10 +- > 26 files changed, 1115 insertions(+), 1029 deletions(-)