From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753933AbbJOQXL (ORCPT <rfc822;w@1wt.eu>);
	Thu, 15 Oct 2015 12:23:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56671 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752744AbbJOQXJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 15 Oct 2015 12:23:09 -0400
From: Jeff Moyer <jmoyer@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com,
        Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org,
        Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] fs/block_dev.c: Remove WARN_ON() when inode writeback fails
References: <20150622184118.GA11277@redhat.com>
	<20150810193725.GC19173@redhat.com>
X-PGP-KeyID: 1F78E1B4
X-PGP-CertKey: F6FE 280D 8293 F72C 65FD  5A58 1FF8 A7CA 1F78 E1B4
X-PCLoadLetter: What the f**k does that mean?
Date: Thu, 15 Oct 2015 12:23:06 -0400
In-Reply-To: <20150810193725.GC19173@redhat.com> (Vivek Goyal's message of
	"Mon, 10 Aug 2015 15:37:25 -0400")
Message-ID: <x498u74gkyd.fsf@segfault.boston.devel.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Vivek Goyal <vgoyal@redhat.com> writes:

> Hi Jens,
>
> Do you have concerns with this patch? If not, can you please include it.

The concept is fine, but:

>> -static void bdev_write_inode(struct inode *inode)
>> +static void bdev_write_inode(struct block_device *bdev)
>>  {
>> +	struct inode *inode = bdev->bd_inode;
>> +	int ret;
>> +
>>  	spin_lock(&inode->i_lock);
>>  	while (inode->i_state & I_DIRTY) {
>>  		spin_unlock(&inode->i_lock);
>> -		WARN_ON_ONCE(write_inode_now(inode, true));
>> +		ret = write_inode_now(inode, true);
>> +		if (ret) {
>> +			char name[BDEVNAME_SIZE] = "";

that initializer isn't necessary.

Cheers,
Jeff