mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: jaxboe@fusionio.com
Cc: Mikulas Patocka <mpatocka@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch] block: make struct block_device cacheline_aligned
Date: Wed, 19 Sep 2012 10:59:09 -0400	[thread overview]
Message-ID: <x498vc683eq.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <x49lig686kv.fsf@segfault.boston.devel.redhat.com> (Jeff Moyer's message of "Wed, 19 Sep 2012 09:50:40 -0400")

Jeff Moyer <jmoyer@redhat.com> writes:

> Hi,
>
> When testing against a pcie ssd or a ramdisk, making the block device
> structure cacheline_aligned provided a significant increase in
> performance:

Self-NACK on this one.  This results in a ton of warnings:

include/linux/fs.h:727: warning: ???__section__??? attribute does not
apply to types
In file included from include/linux/debugfs.h:18,
                 from kernel/trace/trace_probe.h:28,
                 from kernel/trace/trace_kprobe.c:23:
include/linux/fs.h:727: warning: ???__section__??? attribute does not
apply to types

And that leaves me with the task of figuring out if/why this actually
helps.

Cheers,
Jeff
>

  reply	other threads:[~2012-09-19 14:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-19 13:50 Jeff Moyer
2012-09-19 14:59 ` Jeff Moyer [this message]
2012-09-19 15:16   ` Mikulas Patocka
2012-09-19 15:24     ` Jeff Moyer
2012-09-19 15:50       ` Mikulas Patocka
2012-09-19 16:44         ` Jeff Moyer
2012-09-20  0:11           ` Mikulas Patocka
2012-09-19 15:32   ` Richard Kennedy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x498vc683eq.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®