mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: Gabriel Krisman Bertazi <krisman@suse.de>
Cc: Matteo Rizzo <matteorizzo@google.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	io-uring@vger.kernel.org, jordyzomer@google.com, evn@google.com,
	poprdi@google.com, corbet@lwn.net, axboe@kernel.dk,
	asml.silence@gmail.com, akpm@linux-foundation.org,
	keescook@chromium.org, rostedt@goodmis.org,
	dave.hansen@linux.intel.com, ribalda@chromium.org,
	chenhuacai@kernel.org, steve@sk2.org, gpiccoli@igalia.com,
	ldufour@linux.ibm.com
Subject: Re: [PATCH 1/1] Add a new sysctl to disable io_uring system-wide
Date: Wed, 28 Jun 2023 11:59:25 -0400	[thread overview]
Message-ID: <x49bkgzefxe.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <87ilb7ofv6.fsf@suse.de> (Gabriel Krisman Bertazi's message of "Wed, 28 Jun 2023 09:50:37 -0400")

Gabriel Krisman Bertazi <krisman@suse.de> writes:

> Matteo Rizzo <matteorizzo@google.com> writes:
>
>> diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
>> index d85d90f5d000..3c53a238332a 100644
>> --- a/Documentation/admin-guide/sysctl/kernel.rst
>> +++ b/Documentation/admin-guide/sysctl/kernel.rst
>> @@ -450,6 +450,20 @@ this allows system administrators to override the
>>  ``IA64_THREAD_UAC_NOPRINT`` ``prctl`` and avoid logs being flooded.
>>  
>>  
>> +io_uring_disabled
>> +=========================
>> +
>> +Prevents all processes from creating new io_uring instances. Enabling this
>> +shrinks the kernel's attack surface.
>> +
>> += =============================================================
>> +0 All processes can create io_uring instances as normal. This is the default
>> +  setting.
>> +1 io_uring is disabled. io_uring_setup always fails with -EPERM. Existing
>> +  io_uring instances can still be used.
>> += =============================================================
>
> I had an internal request for something like this recently.  If we go
> this route, we could use a intermediary option that limits io_uring
> to root processes only.

This is all regrettable, but this option makes the most sense to me.
Testing for CAP_SYS_ADMIN or CAP_SYS_RAW_IO would work for that third
option, I think.

-Jeff


      reply	other threads:[~2023-06-28 15:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27 12:00 [PATCH 0/1] Add a " Matteo Rizzo
2023-06-27 12:00 ` [PATCH 1/1] Add a new " Matteo Rizzo
2023-06-27 16:23   ` Randy Dunlap
2023-06-27 17:10   ` Bart Van Assche
2023-06-27 18:15     ` Matteo Rizzo
2023-06-28 11:36       ` Ricardo Ribalda
2023-06-28 15:12         ` Matteo Rizzo
2023-06-28 15:59           ` Jeff Moyer
2023-06-28 15:59           ` Ricardo Ribalda
2023-06-28 13:50   ` Gabriel Krisman Bertazi
2023-06-28 15:59     ` Jeff Moyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x49bkgzefxe.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=chenhuacai@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=evn@google.com \
    --cc=gpiccoli@igalia.com \
    --cc=io-uring@vger.kernel.org \
    --cc=jordyzomer@google.com \
    --cc=keescook@chromium.org \
    --cc=krisman@suse.de \
    --cc=ldufour@linux.ibm.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matteorizzo@google.com \
    --cc=poprdi@google.com \
    --cc=ribalda@chromium.org \
    --cc=rostedt@goodmis.org \
    --cc=steve@sk2.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®