From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932429Ab2KEOJu (ORCPT ); Mon, 5 Nov 2012 09:09:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52090 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932276Ab2KEOJs (ORCPT ); Mon, 5 Nov 2012 09:09:48 -0500 From: Jeff Moyer To: Bart Van Assche Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, "James E.J. Bottomley" Subject: Re: [patch,v2 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node References: <1351892763-21325-1-git-send-email-jmoyer@redhat.com> <1351892763-21325-5-git-send-email-jmoyer@redhat.com> <50954818.8050908@acm.org> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Mon, 05 Nov 2012 09:09:43 -0500 In-Reply-To: <50954818.8050908@acm.org> (Bart Van Assche's message of "Sat, 03 Nov 2012 17:36:40 +0100") Message-ID: User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bart Van Assche writes: > On 11/02/12 22:45, Jeff Moyer wrote: >> diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c >> index 2936b44..4db6973 100644 >> --- a/drivers/scsi/scsi.c >> +++ b/drivers/scsi/scsi.c >> @@ -173,16 +173,20 @@ static DEFINE_MUTEX(host_cmd_pool_mutex); >> * NULL on failure >> */ >> static struct scsi_cmnd * >> -scsi_pool_alloc_command(struct scsi_host_cmd_pool *pool, gfp_t gfp_mask) >> +scsi_pool_alloc_command(struct scsi_host_cmd_pool *pool, gfp_t gfp_mask, >> + int node) >> { >> struct scsi_cmnd *cmd; >> >> - cmd = kmem_cache_zalloc(pool->cmd_slab, gfp_mask | pool->gfp_mask); >> + cmd = kmem_cache_alloc_node(pool->cmd_slab, >> + gfp_mask | pool->gfp_mask | __GFP_ZERO, >> + node); >> if (!cmd) >> return NULL; >> >> - cmd->sense_buffer = kmem_cache_alloc(pool->sense_slab, >> - gfp_mask | pool->gfp_mask); >> + cmd->sense_buffer = kmem_cache_alloc_node(pool->sense_slab, >> + gfp_mask | pool->gfp_mask | __GFP_ZERO, >> + node); > > It's not clear to me why __GFP_ZERO is added to the allocation flags ? Hmm, seems I thought this was another case of kmem_cache_zalloc. I'll fix it up. Cheers, Jeff