From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756588AbcECUoM (ORCPT ); Tue, 3 May 2016 16:44:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56815 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756181AbcECUoI (ORCPT ); Tue, 3 May 2016 16:44:08 -0400 From: Jeff Moyer To: mchristi@redhat.com Cc: linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, konrad.wilk@oracle.com, drbd-dev@lists.linbit.com, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, linux-raid@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mtd@lists.infradead.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, osd-dev@open-osd.org, xfs@oss.sgi.com, ocfs2-devel@oss.oracle.com Subject: Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs References: <1460747777-8479-1-git-send-email-mchristi@redhat.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Tue, 03 May 2016 16:44:02 -0400 In-Reply-To: <1460747777-8479-1-git-send-email-mchristi@redhat.com> (mchristi@redhat.com's message of "Fri, 15 Apr 2016 14:15:35 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 03 May 2016 20:44:07 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org mchristi@redhat.com writes: > The following patches begin to cleanup the request->cmd_flags and > bio->bi_rw mess. We currently use cmd_flags to specify the operation, > attributes and state of the request. For bi_rw we use it for similar > info and also the priority but then also have another bi_flags field > for state. At some point, we abused them so much we just made cmd_flags > 64 bits, so we could add more. > > The following patches seperate the operation (read, write discard, > flush, etc) from cmd_flags/bi_rw. > > This patchset was made against linux-next from today April 15 > (git tag next-20160415). > > I put a git tree here: > https://github.com/mikechristie/linux-kernel.git > The patches are in the op branch. Hi, Mike, That git tree doesn't seem to exist. I did manage to apply your patch set on top of next-20160415, though. So... what testing did you do? ;-) I ran into the following problems: - git clone fails - yum segfaults - many blktrace/blkparse issues, including incorrect cpu recorded in traces, null task names, and blkparse outputting nothing for a trace file several gigabytes in size. After that, I decided to back out your patches and test the base linux-next kernel. That kernel has none of those issues. So, either I'm missing some dependencies, or I think we've got some issues to iron out before this thing goes in. Before I dig any further, am I missing something? Cheers, Jeff