From: Jeff Moyer <jmoyer@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Asai Thambi S P <asamymuthupa@micron.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sam Bradshaw <sbradshaw@micron.com>
Subject: Re: [PATCH 05/11] mtip32xx: Set block queue boundary variables
Date: Fri, 01 Jun 2012 09:11:37 -0400 [thread overview]
Message-ID: <x49d35jyy5y.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <4FC85AC9.8010707@kernel.dk> (Jens Axboe's message of "Fri, 01 Jun 2012 08:01:45 +0200")
Jens Axboe <axboe@kernel.dk> writes:
>> Jens, I actually think changing nr_requests makes sense; the only
>> question in my mind is where to do it. (There's no point in artificially
>> limiting the device by default.) IIRC, your general rule was to set this
>> value to 2x the device's queue depth. So, given that this driver
>> doesn't use the blk-tag interfaces, what do you think would be the
>> cleanest way to bump nr_requests in this (and the more general) case?
>
> But it doesn't matter for this case, the driver isn't consuming request
> structures, hence the value set doesn't make any difference. So the only
> limiter of queue depth is the driver itself.
Good point. Nevermind. ;-)
Cheers,
Jeff
prev parent reply other threads:[~2012-06-01 13:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 1:42 Asai Thambi S P
2012-05-31 6:43 ` Jens Axboe
2012-05-31 15:56 ` Asai Thambi S P
2012-05-31 17:12 ` Jeff Moyer
2012-05-31 18:12 ` Asai Thambi S P
2012-05-31 18:40 ` Jeff Moyer
2012-06-01 6:01 ` Jens Axboe
2012-06-01 13:11 ` Jeff Moyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49d35jyy5y.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=asamymuthupa@micron.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=sbradshaw@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®