From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752570AbeAEW4J (ORCPT + 1 other); Fri, 5 Jan 2018 17:56:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45444 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752255AbeAEW4A (ORCPT ); Fri, 5 Jan 2018 17:56:00 -0500 From: Jeff Moyer To: Christoph Hellwig Cc: linux-aio@kvack.org, Avi Kivity , linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] add test for aio poll and io_pgetevents References: <20180104080325.14716-1-hch@lst.de> <20180104080325.14716-7-hch@lst.de> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Fri, 05 Jan 2018 17:55:58 -0500 In-Reply-To: <20180104080325.14716-7-hch@lst.de> (Christoph Hellwig's message of "Thu, 4 Jan 2018 09:03:25 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 05 Jan 2018 22:56:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Christoph Hellwig writes: > + p = fork(); > + switch (p) { [snip] > + default: > + close(pipe1[0]); > + close(pipe2[1]); > + > + io_prep_poll(&iocb, pipe2[0], POLLIN); > + > + ret = io_setup(1, &ctx); > + if (ret) { > + printf("child: io_setup failed\n"); parent > + return 1; > + } > + > + ret = io_submit(ctx, 1, iocbs); > + if (ret != 1) { > + printf("child: io_submit failed\n"); parent Other than that, looks ok to me. Thanks for writing a test! I can fix this up, no need to repost. -Jeff