From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752732AbcEJPpv (ORCPT ); Tue, 10 May 2016 11:45:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59787 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751723AbcEJPpu (ORCPT ); Tue, 10 May 2016 11:45:50 -0400 From: Jeff Moyer To: Shaohua Li Cc: , , Steven Rostedt , , Subject: Re: [PATCH 2/3] blktrace: add missed mask name References: <2c3ee532132f8925dd0be1178e8dee0bba6b448c.1462838969.git.shli@fb.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Tue, 10 May 2016 11:45:47 -0400 In-Reply-To: (Shaohua Li's message of "Mon, 9 May 2016 17:22:14 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 10 May 2016 15:45:49 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Shaohua Li writes: > BLK_TC_NOTIFY is missed in mask_maps, so we can't print out notify or > set mask with 'notify' name. For the text-based interface, yeah. Reviewed-by: Jeff Moyer > > Signed-off-by: Shaohua Li > --- > kernel/trace/blktrace.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c > index 8ae9ea2..9aef865 100644 > --- a/kernel/trace/blktrace.c > +++ b/kernel/trace/blktrace.c > @@ -1552,6 +1552,7 @@ static const struct { > { BLK_TC_COMPLETE, "complete" }, > { BLK_TC_FS, "fs" }, > { BLK_TC_PC, "pc" }, > + { BLK_TC_NOTIFY, "notify" }, > { BLK_TC_AHEAD, "ahead" }, > { BLK_TC_META, "meta" }, > { BLK_TC_DISCARD, "discard" },