From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753551Ab2LQRi7 (ORCPT ); Mon, 17 Dec 2012 12:38:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1773 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752384Ab2LQRi6 (ORCPT ); Mon, 17 Dec 2012 12:38:58 -0500 From: Jeff Moyer To: Jens Axboe Cc: Tejun Heo , Linus Torvalds , "linux-kernel\@vger.kernel.org" Subject: Re: [GIT PULL] core block IO bits for 3.8 References: <50CF3B82.9000904@kernel.dk> <20121217170016.GA2592@htj.dyndns.org> <50CF50AA.7080600@kernel.dk> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Mon, 17 Dec 2012 12:15:01 -0500 In-Reply-To: <50CF50AA.7080600@kernel.dk> (Jens Axboe's message of "Mon, 17 Dec 2012 18:04:42 +0100") Message-ID: User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jens Axboe writes: > On 2012-12-17 18:00, Tejun Heo wrote: >> On Mon, Dec 17, 2012 at 11:06:39AM -0500, Jeff Moyer wrote: >>> Jens Axboe writes: >>> >>>> - Export control of bdi flusher thread CPU mask and default to using the >>>> home node (if known) from Jeff. >>> >>> I certainly wouldn't mind this going in, but I think Tejun NACKed this >>> patch. Tejun? >> >> Hmm... yeah, I would much prefer if this doesn't go in this time. I >> think we need something more generic for threadpools w/ scheduling >> restrictions. It would be possible to retrofit so that the interface >> eventually matches but given that this feature isn't an immediate >> must-have thing, I think it would be better to not do this right now. > > OK, if you have something generic for threadpools in mind, we can wait > with this one. I just thought that a "real" interface was nicer than > manual setting, especially since the flusher threads come and go. Then > you'd need some udev hook to get it set, not even sure how easy that > would be with the weird linkage. > > Jeff, lets default to the node mask at least. Can you resend a patch > that doesn't add the API, but just defaults to setting the affinity to > the cpu mask of the home node? Well, it turns out that the numa node is always -1, since bdi devices always have a null parent. I have a patch set to clean that up, but it depends on my other numa patches in the scsi area that will hopefully go in 3.9. > Linus, how do you want to handle this? I can do a revert and re-send a > pull. For now, I think it would be cleanest if we just reverted the change. Cheers, Jeff