From: Jeff Moyer <jmoyer@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: jens.axboe@oracle.com, linux-kernel@vger.kernel.org,
guijianfeng@cn.fujitsu.com
Subject: Re: [PATCH 1/2] cfq-iosched: Get rid of cfqq wait_busy_done flag
Date: Wed, 09 Dec 2009 14:03:06 -0500 [thread overview]
Message-ID: <x49fx7knf6d.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1260312778-4725-1-git-send-email-vgoyal@redhat.com> (Vivek Goyal's message of "Tue, 8 Dec 2009 17:52:57 -0500")
Vivek Goyal <vgoyal@redhat.com> writes:
> o Get rid of wait_busy_done flag. This flag only tells we were doing wait
> busy on a queue and that queue got request so expire it. That information
> can easily be obtained by (cfq_cfqq_wait_busy() && queue_is_not_empty). So
> remove this flag and keep code simple.
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
prev parent reply other threads:[~2009-12-09 19:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 22:52 Vivek Goyal
2009-12-08 22:52 ` [PATCH 2/2] cfq-iosched: Take care of corner cases of group losing share due to deletion Vivek Goyal
2009-12-09 13:56 ` Jens Axboe
2009-12-09 15:17 ` Vivek Goyal
2009-12-09 18:50 ` Jens Axboe
2009-12-09 19:06 ` Jeff Moyer
2009-12-09 20:39 ` Vivek Goyal
2009-12-09 19:03 ` Jeff Moyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49fx7knf6d.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome