From: Jeff Moyer <jmoyer@redhat.com>
To: oliver.pntr@gmail.com
Cc: linux-kernel@vger.kernel.org, Adrian Bunk <bunk@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Badari Pulavarty <pbadari@us.ibm.com>,
Benjamin LaHaise <bcrl@kvack.org>,
Chris Wright <chrisw@sous-sol.org>,
Davide Libenzi <davidel@xmailserver.org>,
"David S. Miller" <davem@davemloft.net>,
Grant Grundler <grundler@parisc-linux.org>,
Hugh Dickins <hugh@veritas.com>, James Morris <jmorris@namei.org>,
Jan Kara <jack@ucw.cz>, Jeff Garzik <jeff@garzik.org>,
Jeff Roberson <jroberson@chesapeake.net>,
Jens Axboe <jens.axboe@oracle.com>,
Johann Felix Soden <johfel@users.sourceforge.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>, Patrick McHardy <kaber@trash.net>,
Robert Love <rlove@google.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Suparna Bhattacharya <suparna@in.ibm.com>,
Willy Tarreau <w@1wt.eu>, Yan Zheng <yanzheng@21cn.com>,
Zach Brown <zach.brown@oracle.com>
Subject: Re: [OP] v2.6.22.22-op1
Date: Thu, 01 May 2008 10:47:51 -0400 [thread overview]
Message-ID: <x49fxt2axns.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <db9953cd52eb63e471f5fcdcb83b299b@zipernowsky.hu> (oliver@zipernowsky.hu's message of "Thu, 01 May 2008 16:32:01 +0200")
<oliver@zipernowsky.hu> writes:
> I announced the v2.6.22.22-op1 "stable" kernel.
> fs/aio.c | 23 ++++++++++++-----------
> Jeff Moyer (1):
> aio: account I/O wait time properly
This version of the patch introduced a regression for UML. It was
seeing 100% iowait time when it wasn't waiting on any I/O. There was a
follow-up patch which did the io_schedule conditionally, see commit id:
e00ba3dae077f54cfd2af42e939a618caa7a3bca
Cheers,
Jeff
> diff --git a/fs/aio.c b/fs/aio.c
> index dbe699e..b3419c5 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -1170,7 +1171,7 @@ retry:
> ret = 0;
> if (to.timed_out) /* Only check after read evt */
> break;
> - schedule();
> + io_schedule();
> if (signal_pending(tsk)) {
> ret = -EINTR;
> break;
next prev parent reply other threads:[~2008-05-01 14:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 14:32 oliver
2008-05-01 14:47 ` Jeff Moyer [this message]
2008-05-01 14:56 ` Oliver Pinter
2008-05-01 15:14 ` Oliver Pinter
2008-05-01 15:17 ` Oliver Pinter
2008-05-01 14:43 oliver
2008-05-01 15:01 ` Gabriel C
2008-05-01 15:08 ` Oliver Pinter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49fxt2axns.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=bunk@kernel.org \
--cc=chrisw@sous-sol.org \
--cc=davem@davemloft.net \
--cc=davidel@xmailserver.org \
--cc=grundler@parisc-linux.org \
--cc=hugh@veritas.com \
--cc=jack@ucw.cz \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=jmorris@namei.org \
--cc=johfel@users.sourceforge.net \
--cc=jroberson@chesapeake.net \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=oliver.pntr@gmail.com \
--cc=pbadari@us.ibm.com \
--cc=rlove@google.com \
--cc=sds@tycho.nsa.gov \
--cc=suparna@in.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=w@1wt.eu \
--cc=yanzheng@21cn.com \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®