From: Jeff Moyer <jmoyer@redhat.com>
To: Joe Lawrence <joe.lawrence@stratus.com>
Cc: <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v2 1/2] block,scsi: verify return pointer from blk_get_request
Date: Wed, 04 Jun 2014 15:36:34 -0400 [thread overview]
Message-ID: <x49ha40o4al.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1401909633-25931-2-git-send-email-joe.lawrence@stratus.com> (Joe Lawrence's message of "Wed, 4 Jun 2014 15:20:32 -0400")
Joe Lawrence <joe.lawrence@stratus.com> writes:
> The blk-core dead queue checks introduce an error scenario to
> blk_get_request that returns NULL if the request queue has been
> shutdown. This affects the behavior for __GFP_WAIT callers, who should
> verify the return value before dereferencing.
>
> Signed-off-by: Joe Lawrence <joe.lawrence@stratus.com>
> Acked-by: Jiri Kosina <jkosina@suse.cz> [for pktdvd]
> Acked-by: Jeff Moyer <jmoyer@redhat.com>
> Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Heh. Just reviewed by would be better. ;-) I'm sure Jens can sort
that out.
-Jeff
next prev parent reply other threads:[~2014-06-04 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 19:20 [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios Joe Lawrence
2014-06-04 19:20 ` [PATCH v2 1/2] block,scsi: verify return pointer from blk_get_request Joe Lawrence
2014-06-04 19:36 ` Jeff Moyer [this message]
2014-06-04 19:20 ` [PATCH v2 2/2] block,scsi: convert and handle ERR_PTR " Joe Lawrence
2014-06-26 16:08 ` [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios Jeff Moyer
2014-06-26 16:11 ` Jens Axboe
2014-06-26 17:20 ` Jeff Moyer
2014-06-27 3:23 ` Joe Lawrence
2014-06-27 11:59 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49ha40o4al.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=joe.lawrence@stratus.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®