From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753391AbbFHS76 (ORCPT ); Mon, 8 Jun 2015 14:59:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60206 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752214AbbFHS7v (ORCPT ); Mon, 8 Jun 2015 14:59:51 -0400 From: Jeff Moyer To: Tejun Heo Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, vgoyal@redhat.com, avanzini.arianna@gmail.com Subject: Re: [PATCH 4/8] cfq-iosched: minor cleanups References: <1433753973-23684-1-git-send-email-tj@kernel.org> <1433753973-23684-5-git-send-email-tj@kernel.org> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Mon, 08 Jun 2015 14:59:49 -0400 In-Reply-To: <1433753973-23684-5-git-send-email-tj@kernel.org> (Tejun Heo's message of "Mon, 8 Jun 2015 17:59:29 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tejun Heo writes: > * Some were accessing cic->cfqq[] directly. Always use cic_to_cfqq() > and cic_set_cfqq(). > > * check_ioprio_changed() doesn't need to verify cfq_get_queue()'s > return for NULL. It's always non-NULL. Simplify accordingly. > > This patch doesn't cause any functional changes. > > Signed-off-by: Tejun Heo > Cc: Vivek Goyal > Cc: Arianna Avanzini Looks good. I don't much like the "bool is_sync" function parameters. Calls to cic_to_cfqq, cic_set_cfqq, etc would be much easier to read if they took BLK_RW_SYNC and BLK_RW_ASYNC. Certainly not a problem with this patch, though, just a general observation. Reviewed-by: Jeff Moyer