From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932976AbaJaO14 (ORCPT ); Fri, 31 Oct 2014 10:27:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46046 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756578AbaJaO1y (ORCPT ); Fri, 31 Oct 2014 10:27:54 -0400 From: Jeff Moyer To: Jan Kara Cc: axboe@kernel.dk, LKML , stable@vger.kernel.org Subject: Re: [PATCH] block: Fix computation of merged request priority In-Reply-To: <1414698218-11199-1-git-send-email-jack@suse.cz> (Jan Kara's message of "Thu, 30 Oct 2014 20:43:38 +0100") References: <1414698218-11199-1-git-send-email-jack@suse.cz> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Fri, 31 Oct 2014 10:27:50 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jan Kara writes: > Priority of a merged request is computed by ioprio_best(). If one of the > requests has undefined priority (IOPRIO_CLASS_NONE) and another request > has priority from IOPRIO_CLASS_BE, the function will return the > undefined priority which is wrong. Fix the function to properly return > priority of a request with the defined priority. Reviewed-by: Jeff Moyer