From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933336AbcBAPKg (ORCPT ); Mon, 1 Feb 2016 10:10:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39043 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933105AbcBAPKe (ORCPT ); Mon, 1 Feb 2016 10:10:34 -0500 From: Jeff Moyer To: Tahsin Erdogan Cc: Jens Axboe , Aaron Carroll , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] deadline: remove unused struct member References: <1452811292-8568-1-git-send-email-tahsin@google.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Mon, 01 Feb 2016 10:10:32 -0500 In-Reply-To: (Tahsin Erdogan's message of "Sun, 31 Jan 2016 16:54:27 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tahsin Erdogan writes: > Ping? Yeah, commit 63de428b139d3 (deadline-iosched: allow non-sequential batching) removed the use of last_sector, and should have removed the structure member as well (way back in 2008). Reviewed-by: Jeff Moyer > On Thu, Jan 14, 2016 at 2:41 PM, Tahsin Erdogan wrote: >> commit 63de428b139d3d31d86ebe25ae97b33f6540fb7e ("deadline-iosched: >> allow non-sequential batching") removed last use of last_sector. >> >> Signed-off-by: Tahsin Erdogan >> --- >> block/deadline-iosched.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/block/deadline-iosched.c b/block/deadline-iosched.c >> index a753df2..d0dd788 100644 >> --- a/block/deadline-iosched.c >> +++ b/block/deadline-iosched.c >> @@ -39,7 +39,6 @@ struct deadline_data { >> */ >> struct request *next_rq[2]; >> unsigned int batching; /* number of sequential requests made */ >> - sector_t last_sector; /* head position */ >> unsigned int starved; /* times reads have starved writes */ >> >> /* >> @@ -210,8 +209,6 @@ deadline_move_request(struct deadline_data *dd, struct request *rq) >> dd->next_rq[WRITE] = NULL; >> dd->next_rq[data_dir] = deadline_latter_request(rq); >> >> - dd->last_sector = rq_end_sector(rq); >> - >> /* >> * take it off the sort and fifo list, move >> * to dispatch queue >> -- >> 2.6.0.rc2.230.g3dd15c0 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-block" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html