From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754265AbcAHRWo (ORCPT ); Fri, 8 Jan 2016 12:22:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37437 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824AbcAHRWm (ORCPT ); Fri, 8 Jan 2016 12:22:42 -0500 From: Jeff Moyer To: Dave Chinner Cc: "Elliott\, Robert \(Persistent Memory\)" , Ted Tso , "linux-nvdimm\@lists.01.org" , "linux-kernel\@vger.kernel.org" , "xfs\@oss.sgi.com" , "adilger.kernel\@dilger.ca" , Cholerae Hu , "linux-ext4\@vger.kernel.org" Subject: Re: A blocksize problem about dax and ext4 References: <94D0CD8314A33A4D9D801C0FE68B40295BEC985F@G9W0745.americas.hpqcorp.net> <20151224000021.GU19802@dastard> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Fri, 08 Jan 2016 12:22:40 -0500 In-Reply-To: <20151224000021.GU19802@dastard> (Dave Chinner's message of "Thu, 24 Dec 2015 11:00:21 +1100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dave Chinner writes: >> 1. ext4 fails to mount the filesystem, while xfs just disables DAX. >> It seems like they should they be the same. I agree, it would be nice if they were the same. > I don't really care what is done to ext4 here, but I'm not changing > XFS behaviour. I'm expecting mixed dax/non-dax fileystems to be a > thing, with DAX turned on by an inode flag on disk. Indeed, I see > the mount option going away permanently for XFS, and DAX being > controlled completely from on-disk flags. E.g. ext4 encrypted files > need to turn off DAX, while clear text files can be accessed using > DAX. This should happen completely transparently to the user.... The one thing we definitely need is a common way for an application to open a file in dax mode. So, whatever ends up being the interface for xfs in the future sure as heck better work for ext4. I'm also not super keen on just getting rid of the dax mount option. I understand why you'd want to do that, but I think it should stay, with documentation on when you simply won't get dax mappings. Please think about the poor programmers and system administrators that have to use these interfaces. Thanks, Jeff