From: Jeff Moyer <jmoyer@redhat.com>
To: Corrado Zoccolo <czoccolo@gmail.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
axboe@kernel.dk, Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] cfq-iosched: fixing RQ_NOIDLE handling.
Date: Tue, 20 Jul 2010 10:02:45 -0400 [thread overview]
Message-ID: <x49k4oq45fe.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20100719203109.GE32503@redhat.com> (Vivek Goyal's message of "Mon, 19 Jul 2010 16:31:09 -0400")
Vivek Goyal <vgoyal@redhat.com> writes:
> On Mon, Jul 19, 2010 at 12:08:23PM -0400, Jeff Moyer wrote:
>> So, I'm still in favor of Corrado's approach. Are there any remaining
>> dissenting opinions on this?
>
> Nope. I am fine with moving all WRITE_SYNC with RQ_NOIDLE to sync-noidle
> tree and also marking jbd writes as WRITE_SYNC. By bringing dependent
> threads on single service tree, we don't have to worry about slice
> yielding.
>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
Corrado, would you mind reposting the patches and adding:
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Tested-by: Jeff Moyer <jmoyer@redhat.com>
Thanks!
Jeff
next prev parent reply other threads:[~2010-07-20 14:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 15:22 Corrado Zoccolo
2010-07-07 15:56 ` Corrado Zoccolo
2010-07-07 17:03 ` Jeff Moyer
2010-07-07 17:39 ` Corrado Zoccolo
2010-07-07 20:06 ` Jeff Moyer
2010-07-08 14:38 ` Corrado Zoccolo
2010-07-09 10:33 ` Corrado Zoccolo
2010-07-09 13:23 ` Vivek Goyal
2010-07-09 14:07 ` Jeff Moyer
2010-07-09 19:45 ` Corrado Zoccolo
2010-07-09 20:48 ` Jeff Moyer
2010-07-13 19:38 ` Jeff Moyer
2010-07-13 19:56 ` Vivek Goyal
2010-07-13 20:30 ` Jeff Moyer
2010-07-13 20:42 ` Vivek Goyal
2010-07-19 16:08 ` Jeff Moyer
2010-07-19 20:31 ` Vivek Goyal
2010-07-20 14:02 ` Jeff Moyer [this message]
2010-07-20 14:11 ` Christoph Hellwig
2010-07-20 14:26 ` Vivek Goyal
2010-07-20 19:10 ` Corrado Zoccolo
2010-07-20 19:32 ` Vivek Goyal
2010-07-13 21:00 ` Jeff Moyer
2010-07-07 17:50 ` Vivek Goyal
2010-07-08 14:35 ` Vivek Goyal
2010-07-08 14:38 ` Jeff Moyer
2010-07-08 14:45 ` Corrado Zoccolo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49k4oq45fe.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=czoccolo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome