From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757415AbcIPMlE (ORCPT ); Fri, 16 Sep 2016 08:41:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55540 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752977AbcIPMk5 (ORCPT ); Fri, 16 Sep 2016 08:40:57 -0400 From: Jeff Moyer To: Eric Engestrom Cc: , Jens Axboe , Johannes Thumshirn , Dan Williams , Ming Lin , Mike Christie Subject: Re: [PATCH v2] skd: fix assert typo References: <20160916093125.14322-1-eric.engestrom@imgtec.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Fri, 16 Sep 2016 08:40:54 -0400 In-Reply-To: <20160916093125.14322-1-eric.engestrom@imgtec.com> (Eric Engestrom's message of "Fri, 16 Sep 2016 10:31:23 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 16 Sep 2016 12:40:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Engestrom writes: > The assert was missing a `!` to become active, but since that would only turn > it into a complicated codepath for a pr_err(), let's simply replace it. The skd assert macro prints out file and line number, which would have been nice to keep. Sorry I didn't explicitly mention that last time. -Jeff > > CC: Jeff Moyer > Signed-off-by: Eric Engestrom > --- > drivers/block/skd_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c > index 3822eae..c04e92a 100644 > --- a/drivers/block/skd_main.c > +++ b/drivers/block/skd_main.c > @@ -1905,7 +1905,7 @@ static void skd_send_internal_skspcl(struct skd_device *skdev, > break; > > default: > - SKD_ASSERT("Don't know what to send"); > + pr_err("Don't know what to send"); > return; > > } > @@ -2105,7 +2105,7 @@ static void skd_complete_internal(struct skd_device *skdev, > break; > > default: > - SKD_ASSERT("we didn't send this"); > + pr_err("we didn't send this"); > } > }