From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753640AbbFIPF4 (ORCPT ); Tue, 9 Jun 2015 11:05:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45925 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbbFIPFs (ORCPT ); Tue, 9 Jun 2015 11:05:48 -0400 From: Jeff Moyer To: Tejun Heo Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, vgoyal@redhat.com, avanzini.arianna@gmail.com Subject: Re: [PATCHSET block/for-4.2/writeback] block, cgroup: make cfq charge async IOs to the appropriate blkcgs References: <1433753973-23684-1-git-send-email-tj@kernel.org> <20150609030327.GL21465@mtj.duckdns.org> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Tue, 09 Jun 2015 11:05:46 -0400 In-Reply-To: <20150609030327.GL21465@mtj.duckdns.org> (Tejun Heo's message of "Tue, 9 Jun 2015 12:03:27 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tejun Heo writes: > Hey, Jeff. > > On Mon, Jun 08, 2015 at 03:49:56PM -0400, Jeff Moyer wrote: >> Assuming you're ok with dropping patch 5, I'll review patches 6-8 once > > I'll update it to use GPF_NOWAIT. Can't drop it easily as that would > complicate group lookup more complicated w/ pinning and all. > >> they've been reworked to account for that. I took a look at them, and >> they look OK to me. But, if they are going to change, I'd rather wait >> to ack the final versions. > > Hmm... the changes will be simple s/GFP_ATOMIC/GFP_NOWAIT. Shouldn't > affect reviewing, I think. Yeah, I sent this email before realizing that GFP_NOWAIT would work out. I've reviewed the rest of the series. Looks good to me! You did a nice job splitting things up into easily reviewable pieces, so thanks for that. Cheers, Jeff