From: Jeff Moyer <jmoyer@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] block: Fix bad range check in bio_sector_offset
Date: Wed, 29 Aug 2012 13:48:34 -0400 [thread overview]
Message-ID: <x49ligxmvwt.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <yq1fw75pt5q.fsf@sermon.lab.mkp.net> (Martin K. Petersen's message of "Wed, 29 Aug 2012 12:19:45 -0400")
"Martin K. Petersen" <martin.petersen@oracle.com> writes:
>>>>>> "Jeff" == Jeff Moyer <jmoyer@redhat.com> writes:
>
>>> DM would occasionally end up splitting data integrity-enabled
>>> requests incorrectly. The culprit was a bad range check in
>>> bio_sector_offset.
>
> Jeff> The patch looks ok to me, but what is the user visible behavior
> Jeff> when this happens?
>
> We'd occasionally end up mapping a bad integrity scatterlist and the HBA
> would abort the I/O with a protection information error.
Thanks for the explanation, Martin!
Acked-by: Jeff Moyer <jmoyer@redhat.com>
next prev parent reply other threads:[~2012-08-29 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 18:03 Martin K. Petersen
2012-08-29 14:07 ` Jeff Moyer
2012-08-29 16:19 ` Martin K. Petersen
2012-08-29 17:48 ` Jeff Moyer [this message]
2012-08-29 17:16 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49ligxmvwt.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome