From: Jeff Moyer <jmoyer@redhat.com>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: "'Andrew Morton'" <akpm@osdl.org>,
"'Benjamin LaHaise'" <bcrl@kvack.org>, <zach.brown@oracle.com>,
<linux-aio@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [patch] aio: fix buggy put_ioctx call in aio_complete - v2
Date: Thu, 01 Feb 2007 16:13:11 -0500 [thread overview]
Message-ID: <x49lkjhy42g.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <000101c72bb2$a47bfa70$d634030a@amr.corp.intel.com> (Kenneth W. Chen's message of "Fri, 29 Dec 2006 17:34:26 -0800")
==> On Fri, 29 Dec 2006 17:34:26 -0800, "Chen, Kenneth W" <kenneth.w.chen@intel.com> said:
Kenneth> An AIO bug was reported that sleeping function is being called in softirq
Kenneth> context:
Kenneth> The real problem is that the condition check of ctx->reqs_active in
Kenneth> wait_for_all_aios() is incorrect that access to reqs_active is not
Kenneth> being properly protected by spin lock.
Kenneth> This patch adds that protective spin lock, and at the same time removes
Kenneth> all duplicate ref counting for each kiocb as reqs_active is already used
Kenneth> as a ref count for each active ioctx. This also ensures that buggy call
Kenneth> to flush_workqueue() in softirq context is eliminated.
I was finally able to wrap my head around this, and testing has
confirmed that this patch fixes the problem. So,
Acked-by: Jeff Moyer <jmoyer@redhat.com>
Better late than never.
-Jeff
prev parent reply other threads:[~2007-02-01 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-30 1:34 Chen, Kenneth W
2007-02-01 21:13 ` Jeff Moyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49lkjhy42g.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=akpm@osdl.org \
--cc=bcrl@kvack.org \
--cc=kenneth.w.chen@intel.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®