From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751926AbdHCOJA (ORCPT ); Thu, 3 Aug 2017 10:09:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63024 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751868AbdHCOI7 (ORCPT ); Thu, 3 Aug 2017 10:08:59 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2F97A7CDE5 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jmoyer@redhat.com From: Jeff Moyer To: Nikolay Borisov Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] direct-io: Minor cleanups in do_blockdev_direct_IO References: <1501657852-12603-1-git-send-email-nborisov@suse.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Thu, 03 Aug 2017 10:08:57 -0400 In-Reply-To: <1501657852-12603-1-git-send-email-nborisov@suse.com> (Nikolay Borisov's message of "Wed, 2 Aug 2017 10:10:52 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 03 Aug 2017 14:08:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nikolay Borisov writes: > We already get the block counts and the calculate the end block at the > beginning of the function. Let's use the local variables for consistency and > readability. No functional changes > > Signed-off-by: Nikolay Borisov Looks ok to me. Reviewed-by: Jeff Moyer