From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932829AbcILRns (ORCPT ); Mon, 12 Sep 2016 13:43:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33818 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932551AbcILRnk (ORCPT ); Mon, 12 Sep 2016 13:43:40 -0400 From: Jeff Moyer To: Eric Engestrom Cc: , Jens Axboe , Ming Lin , Johannes Thumshirn , Hannes Reinecke , Mike Christie , Dan Williams Subject: Re: [PATCH] skd: fix assert typo References: <20160830102634.22627-1-eric.engestrom@imgtec.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Mon, 12 Sep 2016 13:43:36 -0400 In-Reply-To: <20160830102634.22627-1-eric.engestrom@imgtec.com> (Eric Engestrom's message of "Tue, 30 Aug 2016 11:26:32 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 12 Sep 2016 17:43:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Engestrom writes: > Signed-off-by: Eric Engestrom > --- > drivers/block/skd_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c > index 3822eae..94a7425 100644 > --- a/drivers/block/skd_main.c > +++ b/drivers/block/skd_main.c > @@ -1905,7 +1905,7 @@ static void skd_send_internal_skspcl(struct skd_device *skdev, > break; > > default: > - SKD_ASSERT("Don't know what to send"); > + SKD_ASSERT(!"Don't know what to send"); That's perverse. Just change SKD_ASSERT to pr_err and Robert's your mother's brother. Cheers, Jeff