From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753979AbbKBO6d (ORCPT ); Mon, 2 Nov 2015 09:58:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50181 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753913AbbKBO6c (ORCPT ); Mon, 2 Nov 2015 09:58:32 -0500 From: Jeff Moyer To: Jens Axboe Cc: Vivek Goyal , tj@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails References: <56340117.5000103@kernel.dk> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Mon, 02 Nov 2015 09:58:30 -0500 In-Reply-To: <56340117.5000103@kernel.dk> (Jens Axboe's message of "Fri, 30 Oct 2015 17:45:27 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jens Axboe writes: > On 10/30/2015 09:34 AM, Jeff Moyer wrote: >> From: Vivek Goyal >> >> If a block device is hot removed and later last reference to device >> is put, we try to writeback the dirty inode. But device is gone and >> that writeback fails. >> >> Currently we do a WARN_ON() which does not seem to be the right thing. >> Convert it to a ratelimited kernel warning. > > Any concerns with putting this into 4.4 and marking it for stable? No, that sounds fine to me. > Would be awesome to have a "Fixes:" in here too. OK. I don't know which commit introduced the problem. Do you want something like this? Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1196089 or Fixes: https://www.redhat.com/archives/dm-devel/2015-June/msg00111.html I know some folks don't like mailing list archive links in the commit messages. Cheers, Jeff