From: Jeff Moyer <jmoyer@redhat.com>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: linux-aio@kvack.org, linux-kernel@vger.kernel.org,
Chris Mason <chris.mason@oracle.com>,
Jens Axboe <axboe@kernel.dk>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] AIO: Don't plug the I/O queue in do_io_submit()
Date: Tue, 13 Dec 2011 17:18:41 -0500 [thread overview]
Message-ID: <x49sjkoi08u.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <4EE7C74D.1020306@oracle.com> (Dave Kleikamp's message of "Tue, 13 Dec 2011 15:44:45 -0600")
Dave Kleikamp <dave.kleikamp@oracle.com> writes:
> Asynchronous I/O latency to a solid-state disk greatly increased
> between the 2.6.32 and 3.0 kernels. By removing the plug from
> do_io_submit(), we observed a 34% improvement in the I/O latency.
>
> Unfortunately, at this level, we don't know if the request is to
> a rotating disk or not.
I'm guessing I know the answer to this, but what workload were you
testing, and can you provide more concrete evidence than "latency
greatly increased?" Also, have you tested the effects this has when
using traditional storage for whatever your workload is? I don't feel
comfortable essentially reverting a performance patch without knowing
the entire picture. I will certainly do some testing on my end, too.
Cheers,
Jeff
next prev parent reply other threads:[~2011-12-13 22:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 21:44 Dave Kleikamp
2011-12-13 22:18 ` Jeff Moyer [this message]
2011-12-13 23:26 ` Dave Kleikamp
2011-12-14 20:58 ` Chris Mason
2011-12-16 14:45 ` Jeff Moyer
2011-12-15 1:09 ` Shaohua Li
2011-12-15 16:15 ` Jens Axboe
2011-12-15 16:40 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49sjkoi08u.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=ak@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=chris.mason@oracle.com \
--cc=dave.kleikamp@oracle.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®