From: Jeff Moyer <jmoyer@redhat.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Jens Axboe <jaxboe@fusionio.com>,
czoccolo@gmail.com
Subject: Re: [patch]block cfq: select new workload if priority changed
Date: Fri, 10 Dec 2010 09:56:14 -0500 [thread overview]
Message-ID: <x49sjy5ad81.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1291871853.2323.8.camel@sli10-conroe> (Shaohua Li's message of "Thu, 09 Dec 2010 13:17:33 +0800")
Shaohua Li <shaohua.li@intel.com> writes:
> If priority is changed, continue checking workload_expires and service tree
> count of previous workload is meaningless. We should always choose the workload
I'd change that first sentence to:
If priority is changed, continuing to check workload_expires and
service tree count of the previous workload does not make sense.
> with lowest key of new priority in such case.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
This makes sense to me.
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
next prev parent reply other threads:[~2010-12-10 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 5:17 Shaohua Li
2010-12-10 14:56 ` Jeff Moyer [this message]
2010-12-13 0:39 ` Shaohua Li
2010-12-13 13:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49sjy5ad81.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=czoccolo@gmail.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®