From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932847AbbJ3Pzb (ORCPT ); Fri, 30 Oct 2015 11:55:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45490 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704AbbJ3Pza (ORCPT ); Fri, 30 Oct 2015 11:55:30 -0400 From: Jeff Moyer To: Ming Lei Cc: Jens Axboe , Jason Luo , Linux Kernel Mailing List , Guru Anbalagane , Feng Jin , Tejun Heo Subject: Re: [patch] blk-mq: avoid excessive boot delays with large lun counts References: X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Fri, 30 Oct 2015 11:55:28 -0400 In-Reply-To: (Ming Lei's message of "Fri, 30 Oct 2015 08:37:05 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ming Lei writes: > The following change should be put into blk_mq_init_hctx() too. > > hctx->flags = set->flags & ~BLK_MQ_F_TAG_SHARED; > > and the idea is that we always figure out the shared flag in > following blk_mq_update_tag_set_depth(). OK, this is the part I was missing from your earlier mails. That makes sense, I'll update the patch and repost. Thanks, Ming! -Jeff