mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Jens Axboe <jaxboe@fusionio.com>,
	vgoyal@redhat.com
Subject: Re: [PATCH 1/2]block cfq: don't use atomic_t for cfq_queue
Date: Thu, 23 Dec 2010 10:05:13 -0500	[thread overview]
Message-ID: <x49vd2k7cnq.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1293072333.10593.21.camel@sli10-conroe> (Shaohua Li's message of "Thu, 23 Dec 2010 10:45:33 +0800")

Shaohua Li <shaohua.li@intel.com> writes:

> cfq_queue->ref is used with queue_lock hold, so ref doesn't need to be an atomic
> and atomic operation is slower.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>

  reply	other threads:[~2010-12-23 15:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-23  2:45 Shaohua Li
2010-12-23 15:05 ` Jeff Moyer [this message]
2010-12-23 15:16 ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x49vd2k7cnq.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®