mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	Thomas Swann <tswann@stec-inc.com>,
	Ramprasad Chinthekindi <rchinthekindi@stec-inc.com>,
	Akhil Bhansali <abhansali@stec-inc.com>
Subject: Re: [patch] skd: disable broken discard support
Date: Mon, 25 Apr 2016 15:33:10 -0400	[thread overview]
Message-ID: <x49wpnl4h6x.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <571E7091.7040900@kernel.dk> (Jens Axboe's message of "Mon, 25 Apr 2016 13:31:29 -0600")

Jens Axboe <axboe@kernel.dk> writes:

> On 04/25/2016 01:19 PM, Jeff Moyer wrote:
>> Simply creating a file system on an skd device, followed by mount and
>> fstrim will result in errors in the logs, and even a BUG().  Let's
>> disable it.  As far as I can tell, it hasn't worked right since it was
>> merged.  Note that I've only disabled the reporting here, I haven't
>> removed the implementation bits in the code.  Jens, let me know if you
>> want me to yank it out completely.
>
> I agree with yanking it, but let's remove all the support bits as well
> so we don't have dead code around. If someone wants to resurrect it,
> it's all there in the git history anyway.

Sounds good.

Thanks,
Jeff

      reply	other threads:[~2016-04-25 19:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 19:19 Jeff Moyer
2016-04-25 19:31 ` Jens Axboe
2016-04-25 19:33   ` Jeff Moyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x49wpnl4h6x.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=abhansali@stec-inc.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rchinthekindi@stec-inc.com \
    --cc=tswann@stec-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®