From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753677AbbFIOcq (ORCPT ); Tue, 9 Jun 2015 10:32:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45411 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752372AbbFIOck (ORCPT ); Tue, 9 Jun 2015 10:32:40 -0400 From: Jeff Moyer To: Tejun Heo Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, vgoyal@redhat.com, avanzini.arianna@gmail.com Subject: Re: [PATCH 6/8] cfq-iosched: move cfq_group determination from cfq_find_alloc_queue() to cfq_get_queue() References: <1433753973-23684-1-git-send-email-tj@kernel.org> <1433753973-23684-7-git-send-email-tj@kernel.org> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Tue, 09 Jun 2015 10:32:35 -0400 In-Reply-To: <1433753973-23684-7-git-send-email-tj@kernel.org> (Tejun Heo's message of "Mon, 8 Jun 2015 17:59:31 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tejun Heo writes: > This is necessary for making async cfq_cgroups per-cfq_group instead > of per-cfq_data. While this change makes cfq_get_queue() perform RCU > locking and look up cfq_group even when it reuses async queue, the > extra overhead is extremely unlikely to be noticeable given that this > is already sitting behind cic->cfqq[] cache and the overall cost of > cfq operation. > > Signed-off-by: Tejun Heo > Cc: Vivek Goyal > Cc: Arianna Avanzini Reviewed-by: Jeff Moyer