From: Jeff Moyer <jmoyer@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, dmilburn@redhat.com
Subject: Re: [patch] Revert "block: remove artifical max_hw_sectors cap"
Date: Mon, 20 Jul 2015 16:44:26 -0400 [thread overview]
Message-ID: <x49zj2qwod1.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <55AD5902.7020209@kernel.dk> (Jens Axboe's message of "Mon, 20 Jul 2015 14:24:34 -0600")
Jens Axboe <axboe@kernel.dk> writes:
> On 07/20/2015 01:17 PM, Jeff Moyer wrote:
>>
>> <resent with Jens' email address fixed>
>>
>> Hi,
>>
>> This reverts commit 34b48db66e08, which caused significant iozone
>> performance regressions and uncovered a silent data corruption
>> bug in at least one disk.
>>
>> For SAN storage, we've seen initial write and re-write performance drop
>> 25-50% across all I/O sizes. On locally attached storage, we've seen
>> regressions of 40% for all I/O types, but only for I/O sizes larger than
>> 1MB.
>
> Do we have any understanding of where this regression is coming from?
> Even just basic info like iostats from a run would be useful.
I'll request this information and get back to you. Sorry, I should have
done more digging first, but this seemed somewhat urgent to me.
>> In addition to the performance issues, we've also seen data corruption
>> on one disk/hba combination. See
>> http://marc.info/?l=linux-ide&m=143680539400526&w=2
>
> That's just sucky hardware... That said, it is indeed one of the
> risks. We had basically the same transition from 255 as max sectors,
> since we depended on ATA treating 0 == 256 sectors (as per spec).
Sure, the hardware sucks. I still don't like foisting silent data
corruption on users. Besides, given that this patch went in without any
performance numbers attached, I'd say the risk/reward ratio right now is
in favor of the revert.
Cheers,
Jeff
next prev parent reply other threads:[~2015-07-20 20:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 19:17 Jeff Moyer
2015-07-20 20:24 ` Jens Axboe
2015-07-20 20:44 ` Jeff Moyer [this message]
2015-07-21 13:02 ` Christoph Hellwig
2015-07-29 16:52 ` Jeff Moyer
2015-07-30 0:25 ` Elliott, Robert (Server Storage)
2015-07-30 14:03 ` Jeff Moyer
2015-07-30 13:51 ` Christoph Hellwig
2015-07-30 14:08 ` Jeff Moyer
2015-08-10 17:23 ` Jeff Moyer
2015-08-11 14:28 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2015-07-20 19:17 Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49zj2qwod1.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=dmilburn@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®