From: Jeff Moyer <jmoyer@redhat.com>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: bcrl@kvack.org, axboe@kernel.dk, akpm@linux-foundation.org,
linux-aio@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] aio: remove the needless registration of ring file's private_data
Date: Tue, 22 Jul 2014 09:53:59 -0400 [thread overview]
Message-ID: <x49zjg17b48.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1405996804-8262-1-git-send-email-guz.fnst@cn.fujitsu.com> (Gu Zheng's message of "Tue, 22 Jul 2014 10:40:01 +0800")
Gu Zheng <guz.fnst@cn.fujitsu.com> writes:
> Remove the registration of ring file's private_data, we do not use
> it.
>
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
> ---
> fs/aio.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index 955947e..ad35876 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -192,7 +192,6 @@ static struct file *aio_private_file(struct kioctx *ctx, loff_t nr_pages)
> }
>
> file->f_flags = O_RDWR;
> - file->private_data = ctx;
> return file;
> }
next parent reply other threads:[~2014-07-22 13:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1405996804-8262-1-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-22 13:53 ` Jeff Moyer [this message]
[not found] ` <1405996804-8262-2-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-22 13:54 ` [PATCH 2/4] aio: use the macro rather than the inline magic number Jeff Moyer
2014-07-25 3:13 ` Ming Lei
2014-07-25 5:54 ` Gu Zheng
2014-07-22 14:11 ` Benjamin LaHaise
[not found] ` <1405996804-8262-3-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-22 13:54 ` [PATCH 3/4] aio: fix some comments Jeff Moyer
2014-07-22 14:12 ` Benjamin LaHaise
2014-07-23 3:58 ` Gu Zheng
[not found] ` <1405996804-8262-4-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-22 13:48 ` [PATCH 4/4] aio: use iovec array rather than the single one Jeff Moyer
2014-07-22 15:20 ` Jeff Moyer
2014-07-23 4:05 ` Gu Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49zjg17b48.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®